build(rollup): add assets to the build #209
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinasigartau0798
force-pushed
the
add-assets-path
branch
3 times, most recently
from
7d5100d
to
921c9bd
Compare
rollup.config.js
Outdated
| @@ -4,6 +4,8 @@ import copy from 'rollup-plugin-copy'; | |||
| import license from 'rollup-plugin-license'; | |||
| import scss from 'rollup-plugin-scss'; | |||
| import visualizer from 'rollup-plugin-visualizer'; | |||
| import postcss from 'rollup-plugin-postcss'; | |||
| import copyAssets from 'postcss-copy-assets'; | |||
There was a problem hiding this comment.
We end up using postcss-url because postcss-copy-assets is not maintained
| @@ -73,48 +73,6 @@ https://github.com/webex/widgets. | |||
|
|
|||
| ### Styles | |||
|
|
|||
| In order to properly style Webex Components, we need to import all the fonts, icons, images and core _CSS_ manually. | |||
There was a problem hiding this comment.
While developers won't have to import from Momentum, would they still need to import our assets in their apps?
karinasigartau0798
force-pushed
the
add-assets-path
branch
2 times, most recently
from
f2dc0cd
to
3933385
Compare
karinasigartau0798
force-pushed
the
add-assets-path
branch
3 times, most recently
from
7ca6c55
to
6e41a1e
Compare
|
Don't forget to update |
karinasigartau0798
force-pushed
the
add-assets-path
branch
from
6e41a1e
to
399367e
Compare
karinasigartau0798
force-pushed
the
add-assets-path
branch
from
399367e
to
14427ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the assets to the assets folder in the build directory and resolve the paths in the CSS file.
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-208853