Accounts - 4.x System E2E Tests #5285
Conversation
avkos
requested review from
nazarhussain,
jdevcs,
luu-alex,
Muhammad-Altabba,
nikoulai and
spacesailor24
There was a problem hiding this comment.
Crypto.subtle is available in firefox 34 , there is error in tests because : "This feature is available only in secure contexts (HTTPS)" and CI logs shows tests are running without SSL
web3-eth-accounts: TypeError: crypto_1.crypto.web.subtle is undefined
350
web3-eth-accounts: getBrowserKey@http://localhost:43915/__cypress/tests?p=test/integration/account.test.ts:54252:18
|
Your Render PR Server URL is https://web3js-docs-pr-5285.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbjqk3vho1kvb2r30gtg. |
templates/cypress/plugins/index.js
Outdated
| @@ -27,6 +27,7 @@ module.exports = (on, config) => { | |||
| config.env.WEB3_SYSTEM_TEST_MNEMONIC = process.env.WEB3_SYSTEM_TEST_MNEMONIC; | |||
| config.env.WEB3_SYSTEM_TEST_PORT = process.env.WEB3_SYSTEM_TEST_PORT; | |||
| config.env.WEB3_SYSTEM_TEST_PROVIDER = process.env.WEB3_SYSTEM_TEST_PROVIDER; | |||
| config.env.WEB3_SYSTEM_TEST_CLIENT = process.env.WEB3_SYSTEM_TEST_CLIENT; | |||
There was a problem hiding this comment.
we should refer client for eth node, in our repo.
| beforeAll(async () => { | ||
| contract = await contract.deploy(deployOptions).send(sendOptions); | ||
| let contractDeployed: Contract<typeof ERC20TokenAbi>; | ||
| beforeEach(async () => { |
There was a problem hiding this comment.
Sorry, do we really need here to have those repeated before each?
| let web3: Web3; | ||
|
|
||
| beforeAll(async () => { | ||
| beforeEach(async () => { |
There was a problem hiding this comment.
Do all the lines need to be executed beforeEach? I mean, It seems the following needed to be executed only once:
clientUrl = getSystemTestProvider();
web3 = new Web3(clientUrl);
await waitForOpenConnection(web3);
Right?
| // if (process.env.WEB3_SYSTEM_TEST_ENGINE === 'firefox') { | ||
| // const port = parseInt(String(Math.random() * 10000 + 10000)); | ||
| // config.clientCertificates = [ | ||
| // { | ||
| // url: 'https://web3.js', | ||
| // certs: [ | ||
| // { | ||
| // cert: './cypress/.cert/cert.pem', | ||
| // key: './cypress/.cert/key.pem', | ||
| // }, | ||
| // ], | ||
| // }, | ||
| // ]; | ||
| // config.e2e.port = port; | ||
| // config.e2e.hosts = { | ||
| // 'web3.js': '127.0.0.1', | ||
| // }; | ||
| // config.e2e.baseUrl = `https://web3.js:${port}`; | ||
| // } |
There was a problem hiding this comment.
Could you please add a comment that possibly refers to an issue that describes why this code is commented. And when this code is supposed to be uncommented.
Thanks,
| expect.objectContaining({ from: accounts[0] }), | ||
| ); | ||
| }); | ||
| itIf(!isIpc)( |
There was a problem hiding this comment.
Sorry, why this test should not apply to IPC? And why it was working when it was applied to all including IPC?
And if there a good reason for that, could we please, have a small comment hereon why this test should not apply to IPC?
Description
#5038
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.