Adding hebrew translation #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @IlanKro can you update the |
done |
|
@RichardLindhout Can you check this out? I wouldn't expect to see update snapshot tests since nothing really changed against them. |
RichardLindhout
approved these changes
Mar 2, 2023
|
Looks good! |
|
Hey @IlanKro , I was wondering how did you get RTL support in the first place? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Adding hebrew translations, I used the arabic (an rtl language) as a template, so it should work similarly.
I didn't test if it look right becuase I am not sure how to test only a library, but it should work if Arabic work.
If I have to test it before please tell me how I should do it, thanks :).