Add serverCertificateHashes test server #50263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a second webtransport server, in order to test connection with a server, that has a self-signed certificate together with serverCertificateHashes. See web-platform-tests/rfcs#216
wpt-pr-bot
added
infra
serve
webtransport
wg-s_webtransport
wptrunner
wpt-pr-bot
requested review from
bashi,
DanielRyanSmith,
foolip,
nidhijaju and
yutakahirano
nidhijaju
reviewed
Jan 27, 2025
| """ | ||
| Specify, if the server should generate a certificate or use an existing certificate | ||
| USEPREGENERATED: use existing certificate | ||
| GENERATEDVALIDSERVERCERTIFICATEHASHCERT: generate a certificate compatible to server cert hashes |
There was a problem hiding this comment.
minor nit:
Suggested change
| GENERATEDVALIDSERVERCERTIFICATEHASHCERT: generate a certificate compatible to server cert hashes | |
| GENERATEDVALIDSERVERCERTIFICATEHASHCERT: generate a certificate compatible with server cert hashes |
| """ | ||
| USEPREGENERATED = 1, | ||
| GENERATEDVALIDSERVERCERTIFICATEHASHCERT = 2 | ||
| # TODO add cases for invalid certificates |
There was a problem hiding this comment.
Suggested change
| # TODO add cases for invalid certificates | |
| # TODO(jgraham): add cases for invalid certificates |
| @@ -507,18 +521,31 @@ class WebTransportH3Server: | |||
| :param host: Host from which to serve. | |||
| :param port: Port from which to serve. | |||
| :param doc_root: Document root for serving handlers. | |||
| :paran cert_mode: The used certificate mode can be | |||
There was a problem hiding this comment.
Suggested change
| :paran cert_mode: The used certificate mode can be | |
| :param cert_mode: The used certificate mode can be |
| @@ -499,6 +503,16 @@ def add(self, ticket: SessionTicket) -> None: | |||
| def pop(self, label: bytes) -> Optional[SessionTicket]: | |||
| return self.tickets.pop(label, None) | |||
|
|
|||
| class WebTransportCertificateGeneration(Enum): | |||
There was a problem hiding this comment.
If we're assigning them integer values, we can use IntEnum and skip the additional import, right?
Suggested change
| class WebTransportCertificateGeneration(Enum): | |
| class WebTransportCertificateGeneration(IntEnum): |
Comment on lines
+509
to
+510
| USEPREGENERATED: use existing certificate | ||
| GENERATEDVALIDSERVERCERTIFICATEHASHCERT: generate a certificate compatible to server cert hashes |
There was a problem hiding this comment.
This makes it a little bit more readable:
Suggested change
| USEPREGENERATED: use existing certificate | |
| GENERATEDVALIDSERVERCERTIFICATEHASHCERT: generate a certificate compatible to server cert hashes | |
| USE_PREGENERATED: use existing certificate | |
| GENERATE_VALID_SERVER_CERTIFICATE_HASH_CERT: generate a certificate compatible to server cert hashes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a second webtransport server, in order to test connection with a server, that has a self-signed certificate together with serverCertificateHashes.
See web-platform-tests/rfcs#216