Tentative: match new PR about 2E "unless the element is marked as presentational" #50002

giacomo-petri · 2025-01-09T20:55:34Z

Closes: web-platform-tests/interop-accessibility#167

Ambiguity: https://www.w3.org/TR/accname-1.2/#comp_host_language_label

This PR adds tests for:

elements receiving the accessible name from host language label elements (both explicit and implicit) with role="presentation";
elements with role=presentation that do not receive the accessible name from host language label elements (both explicit and implicit)
elements with role=presentation that receives the accessible name from host language label elements (both explicit and implicit) due to presentational roles conflict resolution

Note: since I created tests for acc name related to presentational roles conflict resolution, I have also included tests to verify that the computed role aligns with the expected result.

… presentation

accname/name/comp_host_language_label.tentative.html

lolaodelola · 2025-01-13T12:26:41Z

Hi @giacomo-petri, I'm coming from the review of PR 2405. This looks good to me for the most part, Scott's addressed some of the initial confusion. I noted some semantic confusion in the naming of the test sections vs what is being tested. While role="presentation" and role="none" do the same thing, it's confusing to have the test refer to testing role="none" on an input but the actual test setup has role="presentation" on the input. In most cases where you mention testing for none, you're testing for presentation, I didn't want to litter your inbox with every instance of this but I've noted two above.

Unless there's something I'm missing, the heading and test setup should match to avoid confusion for folks when reading.

Thank you for this work!

giacomo-petri · 2025-01-13T13:17:31Z

Done

lolaodelola · 2025-01-14T15:27:48Z

Thanks @giacomo-petri! You have some lint errors, once you've addressed those I'll be happy to approve this.

accname/name/comp_host_language_label.tentative.html

giacomo-petri · 2025-01-15T22:59:50Z

Thanks all:

replaced .ex with .ex-label (and added where missing)
replaced all role="presentation" with role="none"

cookiecrook

Thanks for the updates! Almost ready!

accname/name/comp_host_language_label.tentative.html

wai-aria/role/role_none_conflict_resolution.tentative.html

Co-authored-by: James Craig <[email protected]>

- added readonly testcases with and w/o disabled - replaced [role none] witg [role=none] in data-testname

replaced role none with role=none

added cross reference comment

add cross reference comment

expectations moved from svg to circle

table fix (added THs and TDs)

cookiecrook · 2025-01-21T20:12:38Z

Fix the lint errors and the bots will kick off another attempt to get that last CI result.

giacomo-petri · 2025-01-21T22:11:28Z

Lint errors fixed!

accname/name/comp_host_language_label.tentative.html

cookiecrook · 2025-01-31T01:54:44Z

accname/name/comp_host_language_label.tentative.html

+    <table data-expectedlabel="caption" data-testname="html: table wrapping caption[role=none]" class="ex-label">
+      <caption role="none">caption</caption>


@scottaohara Do you concur with this test expectation?

…ions/reasons

cookiecrook

The label tests for invalidated role none should stay in this PR. Thanks for adding those comments.

However, any label test where the same element has an expected role of none should be removed from this PR entirely, and added to a new issue (keyword "blocked by testability") in the interop-accessibility repo. We can't commit these into WPT yet, because there is no reliable way to get a label from a non-existent accessibility object (role none/generic/etc). The test would be exposing implementation details, but not failures.

To my knowledge, no engines compute the label on a non-existent accessibility object... I think Chrome just returns the empty string when there is no backing object, but that's an implementation detail, not a test.

cookiecrook · 2025-01-31T17:16:16Z

accname/name/comp_host_language_label.tentative.html

+    <fieldset role="none" data-expectedlabel="" data-testname="html: fieldset[role=none]>legend (role none set on fieldset affects fieldset acc name)" class="ex-label"><legend>legend</legend></fieldset>
+
+    <h2>HTML fieldset role="none" wrapping legend with role="none"</h2>
+    <fieldset role="none" data-expectedlabel="" data-testname="html: fieldset[role=none]>legend[role=none] (role none set on fieldset affects fieldset acc name)" class="ex-label"><legend role="none">legend</legend></fieldset>


This is one of the tests that should be moved to a new "blocked by testability" issue. You can't validly (yet) expect to be able to test computedlabel on an element with no role...

cookiecrook · 2025-01-31T17:16:26Z

accname/name/comp_host_language_label.tentative.html

+    <fieldset data-expectedlabel="legend" data-testname="html: fieldset>legend[role=none] (role none set on legend doesn't affect fieldset acc name)" class="ex-label"><legend role="none">legend</legend></fieldset>
+
+    <h2>HTML fieldset with role="none" wrapping legend</h2>
+    <fieldset role="none" data-expectedlabel="" data-testname="html: fieldset[role=none]>legend (role none set on fieldset affects fieldset acc name)" class="ex-label"><legend>legend</legend></fieldset>


This is one of the tests that should be moved to a new "blocked by testability" issue. You can't validly (yet) expect to be able to test computedlabel on an element with no role...

cookiecrook · 2025-01-31T17:19:43Z

accname/name/comp_host_language_label.tentative.html

+    </label>
+
+    <h2>HTML img with role="none" and non empty alt</h2>
+    <img src="https://www.w3.org/assets/logos/w3c/w3c-no-bars.svg" role="none" alt="w3c logo" data-expectedlabel="" data-testname="html: img[role=none][alt]:not([alt='']) (role none takes precedence over empty alt)" class="ex-label">


This is one of the tests that should be moved to a new "blocked by testability" issue. You can't validly (yet) expect to be able to test computedlabel on an element with no role...

cookiecrook · 2025-01-31T17:20:08Z

accname/name/comp_host_language_label.tentative.html

+    <h3>HTML label encapsulation</h3>
+    <label>
+      <span>input label</span>
+      <input type="text" data-expectedlabel="" data-testname="html: label>input[role=none][disabled] (with label encapsulation, role none applied due to disabled input)" class="ex-label" role="none" disabled>


This is one of the tests that should be moved to a new "blocked by testability" issue. You can't validly (yet) expect to be able to test computedlabel on an element with no role...

cookiecrook · 2025-01-31T17:21:30Z

accname/name/comp_host_language_label.tentative.html

+    </table>
+
+    <h2>HTML table with role="none" wrapping caption</h2>
+    <table role="none" data-expectedlabel="" data-testname="html: table[role=none]>caption (role none set on table affects fieldset acc name)" class="ex-label">


This is one of the tests that should be moved to a new "blocked by testability" issue. You can't validly (yet) expect to be able to test computedlabel on an element with no role...

cookiecrook · 2025-01-31T17:21:42Z

accname/name/comp_host_language_label.tentative.html

+    </table>
+
+    <h2>HTML table role="none" wrapping caption with role="none"</h2>
+    <table role="none" data-expectedlabel="" data-testname="html: table[role=none]>caption[role=none] (role none set on table affects fieldset acc name)" class="ex-label">


This is one of the tests that should be moved to a new "blocked by testability" issue. You can't validly (yet) expect to be able to test computedlabel on an element with no role...

Acc test for input with acc name coming from label elements with role…

43184ee

… presentation

wpt-pr-bot added the accname label Jan 9, 2025

wpt-pr-bot assigned cookiecrook Jan 9, 2025

wpt-pr-bot requested review from cookiecrook, jnurthen, MelSumner and spectranaut January 9, 2025 20:55

giacomo-petri added 2 commits January 9, 2025 22:37

Update comp_host_language_label.tentative.html

8fdb651

Update comp_host_language_label.tentative.html

28d3673

giacomo-petri changed the title ~~input elements receiving the accessible name from label elements (both explicit and implicit) with role="presentation"~~ Tentative: match new PR about 2E "unless the element is marked as presentational" Jan 11, 2025

Create role_none_conflict_resolution.tentative.html

0af612d

wpt-pr-bot added wai-aria wg-wai_pf labels Jan 11, 2025

lolaodelola reviewed Jan 13, 2025

View reviewed changes

accname/name/comp_host_language_label.tentative.html Outdated Show resolved Hide resolved

lolaodelola reviewed Jan 13, 2025

View reviewed changes

accname/name/comp_host_language_label.tentative.html Outdated Show resolved Hide resolved

giacomo-petri added 2 commits January 13, 2025 14:16

Update comp_host_language_label.tentative.html

84dddad

Update role_none_conflict_resolution.tentative.html

828fd3c

giacomo-petri requested a review from lolaodelola January 13, 2025 13:17

cookiecrook requested changes Jan 15, 2025

View reviewed changes

accname/name/comp_host_language_label.tentative.html Outdated Show resolved Hide resolved

giacomo-petri added 2 commits January 15, 2025 23:56

Update comp_host_language_label.tentative.html

ba51332

Update role_none_conflict_resolution.tentative.html

6dff699

giacomo-petri requested a review from cookiecrook January 15, 2025 23:00

spectranaut removed request for spectranaut and lolaodelola January 16, 2025 18:09

cookiecrook requested changes Jan 17, 2025

View reviewed changes

Apply suggestions from code review

03eb59d

Co-authored-by: James Craig <[email protected]>

giacomo-petri and others added 7 commits January 17, 2025 08:56

Apply suggestions from code review

ff3b093

Co-authored-by: James Craig <[email protected]>

Update role_none_conflict_resolution.tentative.html

a2cb698

- added readonly testcases with and w/o disabled - replaced [role none] witg [role=none] in data-testname

Update comp_host_language_label.tentative.html

46f594d

replaced role none with role=none

Update comp_host_language_label.tentative.html

ba37e50

added cross reference comment

Update role_none_conflict_resolution.tentative.html

3fa7dda

add cross reference comment

Update comp_host_language_label.tentative.html

c03918e

expectations moved from svg to circle

Update comp_host_language_label.tentative.html

87d1daf

table fix (added THs and TDs)

Update comp_host_language_label.tentative.html

ca57c8f

cookiecrook requested changes Jan 31, 2025

View reviewed changes

updated all data-testname with valid CSS selectors and added expectat…

9ee3cf6

…ions/reasons

wpt-pr-bot added the wg-wai_aria label Jan 31, 2025

giacomo-petri requested a review from cookiecrook January 31, 2025 08:11

cookiecrook requested changes Jan 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tentative: match new PR about 2E "unless the element is marked as presentational" #50002

Tentative: match new PR about 2E "unless the element is marked as presentational" #50002

giacomo-petri commented Jan 9, 2025 •

edited

Loading

lolaodelola commented Jan 13, 2025

giacomo-petri commented Jan 13, 2025

lolaodelola commented Jan 14, 2025

giacomo-petri commented Jan 15, 2025

cookiecrook left a comment

cookiecrook commented Jan 21, 2025

giacomo-petri commented Jan 21, 2025

cookiecrook Jan 31, 2025

cookiecrook left a comment •

edited

Loading

cookiecrook Jan 31, 2025 •

edited

Loading

cookiecrook Jan 31, 2025 •

edited

Loading

cookiecrook Jan 31, 2025 •

edited

Loading

cookiecrook Jan 31, 2025 •

edited

Loading

cookiecrook Jan 31, 2025 •

edited

Loading

cookiecrook Jan 31, 2025 •

edited

Loading

		<table data-expectedlabel="caption" data-testname="html: table wrapping caption[role=none]" class="ex-label">
		<caption role="none">caption</caption>

Tentative: match new PR about 2E "unless the element is marked as presentational" #50002

Are you sure you want to change the base?

Tentative: match new PR about 2E "unless the element is marked as presentational" #50002

Conversation

giacomo-petri commented Jan 9, 2025 • edited Loading

lolaodelola commented Jan 13, 2025

giacomo-petri commented Jan 13, 2025

lolaodelola commented Jan 14, 2025

giacomo-petri commented Jan 15, 2025

cookiecrook left a comment

Choose a reason for hiding this comment

cookiecrook commented Jan 21, 2025

giacomo-petri commented Jan 21, 2025

cookiecrook Jan 31, 2025

Choose a reason for hiding this comment

cookiecrook left a comment • edited Loading

Choose a reason for hiding this comment

cookiecrook Jan 31, 2025 • edited Loading

Choose a reason for hiding this comment

cookiecrook Jan 31, 2025 • edited Loading

Choose a reason for hiding this comment

cookiecrook Jan 31, 2025 • edited Loading

Choose a reason for hiding this comment

cookiecrook Jan 31, 2025 • edited Loading

Choose a reason for hiding this comment

cookiecrook Jan 31, 2025 • edited Loading

Choose a reason for hiding this comment

cookiecrook Jan 31, 2025 • edited Loading

Choose a reason for hiding this comment

giacomo-petri commented Jan 9, 2025 •

edited

Loading

cookiecrook left a comment •

edited

Loading

cookiecrook Jan 31, 2025 •

edited

Loading

cookiecrook Jan 31, 2025 •

edited

Loading

cookiecrook Jan 31, 2025 •

edited

Loading

cookiecrook Jan 31, 2025 •

edited

Loading

cookiecrook Jan 31, 2025 •

edited

Loading

cookiecrook Jan 31, 2025 •

edited

Loading