-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new contrast-color feature #2304
base: main
Are you sure you want to change the base?
Conversation
I spent some time looking into CSSWG conversations and specs, but couldn't form a definitive point of view on what's needed here. |
@captainbrosset I'm trying to work this out in terms of whether or not we can be helpful developers. I think there are two plausible routes here: disambiguation or pretending it doesn't exist yet. If we think this idea has enough attention that a lot of developers might have heard about it (from places that are not CSSWG issues), then main thing we can do at this point seems to be to provide disambiguation: Looking around, it does appear that there have been articles on both In that scenario, it might make sense to create a discouraged On the other hand, if we think that this is still obscure, flying under the radar, then let's close this PR and put it off until there's more developer interest. |
I could go either way, but given that Although, to make the other case, early specs often go through bike shedding, and I'm not sure where to set the bar for disambiguating renamed features. Another instance would be I think as long as we are okay with setting a precedent that may lead to more than just a handful of discouraged disambiguation keys, this one makes sense to disambiguate. |
I could also go both ways. The 2 smashing articles you found both talk about the old Which makes me think that there's value in publishing a discouraged feature for Is that last point true though? It makes a lot of sense to publish discouraged features for things that did exist for a while, and maybe don't anymore, or do but have better alternatives. At first sight, it seems to make less sense to do so for features that never saw the light of day. But, when a feature is born, we don't yet know whether it will see day light. As Chromium starts to create web-features for all new things as part of its shipping process, we will have a lot of features that are Chromium-only-behind-flag things. And these can either continue on, or get merged or renamed, or just plain stop. So, I guess my conclusion is that I'm leaning towards creating a discouraged feature, just to put ourselves in the position of having done so while the work was happening in Safari, and later having to live with that ID being reserved, and that feature now being discouraged. |
But, if we do create discourage color-contrast feature, then we also need to create a contrast-color feature to point to (via the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good!
It is missing a dist
file for contrast-color
.
Edit: Nevermind, it's there.
Don't look at the MDN page for this feature, it's outdated. See mdn/content#36904.