Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checklist for BCD upgrades workflow #2073

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Oct 24, 2024

A follow up to #2043.

This workflow on the first attempt: https://github.com/web-platform-dx/web-features/actions/runs/11496579249/job/31998472971?pr=2071#logs

Problems:

  • No write permissions for the PR
  • No checkout to run the diff against (I tested this bit and I have no idea why this worked on my own repo but not here, even though it obviously SHOULD have failed 🙄)

To fix this, I did these things:

  • Switched to using https://github.com/dependabot/fetch-metadata instead (to avoid a slow checkout)

    Unfortunately, this makes the PR basically untestable—you can't force Dependabot to do anything. We'll find out if it works tomorrow, I guess.

  • Set continue-on-error for both steps, since failures of this workflow shouldn't mark the PR as failing

@ddbeck
Copy link
Collaborator Author

ddbeck commented Oct 24, 2024

@Elchi3 if you'd have another look at this, I'd appreciate it. 🙏

@github-actions github-actions bot added the tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings label Oct 24, 2024
Copy link
Collaborator

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot cleaner to me. Fingers crossed this time :)

@Elchi3 Elchi3 merged commit 53f925b into web-platform-dx:main Oct 24, 2024
3 checks passed
@Elchi3
Copy link
Collaborator

Elchi3 commented Oct 24, 2024

@ddbeck this seems to fail on regular PRs: https://github.com/web-platform-dx/web-features/actions/runs/11499270152

Invalid workflow file: .github/workflows/bcd_upgrade_checklist.yml#L19
The workflow is not valid. .github/workflows/bcd_upgrade_checklist.yml (Line: 19, Col: 13): Unexpected symbol: '"@mdn/browser-compat-data"'. Located at position 62 within expression: contains(steps.dependabot-metadata.outputs.dependency-names, "@mdn/browser-compat-data"

@ddbeck ddbeck deleted the checklist-fix branch October 24, 2024 13:56
ddbeck added a commit to ddbeck/web-features that referenced this pull request Oct 24, 2024
Elchi3 pushed a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants