Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document, document fragment, document type #1983

Closed
wants to merge 18 commits into from

Conversation

autonome
Copy link
Collaborator

@autonome autonome commented Oct 16, 2024

kitchen sink at this point, pulled from various drafts.

Ok, whittling down to keys which match the following criteria:

  • superkeys like api.Document
  • keys which refer directly to the document itself or change it, eg document.lastModified and `document.
  • document-level collections, eg document.images and document.forms (yes, there may be "primary" features for the thing being collected but the document shortcut is document-level)

Need to determine whether to put other interface impls in the feature or in the interface - eg, document.append is impl of Element... so do we add all the append keys to their feature or add them all to an Element feature? TBD will ask in chat/meeting.

Will see what's left after that culling and classify the remainders.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 16, 2024
@autonome autonome changed the title Add document feature Add document, document fragment, document type Oct 17, 2024
@autonome autonome marked this pull request as ready for review October 18, 2024 09:14
@autonome
Copy link
Collaborator Author

autonome commented Oct 18, 2024

Ready for a first pass. There's not any real standalone feature candidates in the key list for Document. There's a couple notes on Caniuse keys that are related.

Open question is what approach for keys like createTreeWalker - there'll be a TreeWalker feature coming out of the DOM PR I've got going. Things like Ranges also will be feature. I assumed it'd go with the specific feature vs leaving it here, but worth asking if there's different opinion there.

Aside from one-off keys that'll get poached into future features, some things that might make standalone features:

  • head as noted in the PR
  • designMode
  • referrer
  • dir (add to other intl features/group?)
  • maybe there's a better home for the visibility keys?

Aha, so there's this: https://caniuse.com/dom-manip-convenience

The description shows its age enough that I'm skeptical we want to align around that bag of APIs specifically.

However, there may be something to a "working w/ the DOM and nodes" collection of features, looking through developer lens.

@ddbeck
Copy link
Collaborator

ddbeck commented Oct 23, 2024

I think a lot of this stuff is going to get swept into a monolithic DOM feature. I'd appreciate if other reviewers also had a look through https://github.com/web-platform-dx/web-features/pull/2007/files#r1813040012.

@autonome
Copy link
Collaborator Author

Closing to fold into #2007

@autonome autonome closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants