Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dll): json stringify non-numeric request in code generation #9087

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Jan 22, 2025

Summary

fix #9076

In webpack, the request type can be a number, so when using JSON.stringify, no need to check if the request is a numeric string. In Rspack, we need to do this, or it will break existing tests.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ca83032
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/679128605b42f70008596000
😎 Deploy Preview https://deploy-preview-9087--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #9087 will not alter performance

Comparing inottn:fix/dll (ca83032) with main (fedb661)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Invalid code generated when using DLL plugins and mode: development or optimization.moduleIds: named
1 participant