Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: duplicate memory allocate in fs write #8780

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

perf: duplicate memory allocate in fs write #8780

wants to merge 3 commits into from

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Dec 19, 2024 •
edited
Loading

Summary

perf: duplicate memory allocate in fs write

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Dec 19, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 19, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 55c5035
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6763f22b05a7dc0008fad1b5

@SyMind
Copy link
Member Author

SyMind commented Dec 19, 2024

!bench

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #8780 will not alter performance

Comparing SyMind:perf-fs-write (55c5035) with main (22f3bb0)

Summary

✅ 1 untouched benchmarks

@SyMind SyMind marked this pull request as ready for review December 19, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release: performance release: performance related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SyMind