refactor: rename FileSystem to SyncFileSystem

crates/node_binding/src/resolver_factory.rs

@@ -2,7 +2,7 @@ use std::sync::Arc;
 
 use napi_derive::napi;
 use rspack_core::{Resolve, ResolverFactory};
-use rspack_fs::{NativeFileSystem, ReadableFileSystem};
+use rspack_fs::{NativeFileSystem, SyncReadableFileSystem};
 
 use crate::{
   raw_resolve::{
@@ -15,7 +15,7 @@ use crate::{
 pub struct JsResolverFactory {
   pub(crate) resolver_factory: Option<Arc<ResolverFactory>>,
   pub(crate) loader_resolver_factory: Option<Arc<ResolverFactory>>,
-  pub(crate) input_filesystem: Arc<dyn ReadableFileSystem>,
+  pub(crate) input_filesystem: Arc<dyn SyncReadableFileSystem>,
 }
 
 #[napi]

crates/rspack_core/src/cache/mod.rs

@@ -4,7 +4,7 @@ pub mod persistent;
 
 use std::{fmt::Debug, sync::Arc};
 
-use rspack_fs::ReadableFileSystem;
+use rspack_fs::SyncReadableFileSystem;
 
 use self::{disable::DisableCache, memory::MemoryCache, persistent::PersistentCache};
 use crate::{Compilation, CompilerOptions, ExperimentCacheOptions};
@@ -28,7 +28,7 @@ pub trait Cache: Debug + Send + Sync {
 
 pub fn new_cache(
   compiler_option: Arc<CompilerOptions>,
-  fs: Arc<dyn ReadableFileSystem>,
+  fs: Arc<dyn SyncReadableFileSystem>,
 ) -> Arc<dyn Cache> {
   match &compiler_option.experiments.cache {
     ExperimentCacheOptions::Disabled => Arc::new(DisableCache),

crates/rspack_core/src/cache/persistent/mod.rs

@@ -3,7 +3,7 @@ pub mod storage;
 
 use std::sync::Arc;
 
-use rspack_fs::ReadableFileSystem;
+use rspack_fs::SyncReadableFileSystem;
 use rspack_paths::{AssertUtf8, Utf8PathBuf};
 use rustc_hash::FxHashSet as HashSet;
 
@@ -28,7 +28,7 @@ pub struct PersistentCache {
 }
 
 impl PersistentCache {
-  pub fn new(option: &PersistentCacheOptions, fs: Arc<dyn ReadableFileSystem>) -> Self {
+  pub fn new(option: &PersistentCacheOptions, fs: Arc<dyn SyncReadableFileSystem>) -> Self {
     let storage = Arc::new(MemoryStorage::default());
     Self {
       snapshot: Snapshot::new(option.snapshot.clone(), fs, storage.clone()),

crates/rspack_core/src/cache/persistent/snapshot/mod.rs

@@ -4,7 +4,7 @@ mod strategy;
 use std::sync::Arc;
 
 use rspack_cacheable::{from_bytes, to_bytes};
-use rspack_fs::ReadableFileSystem;
+use rspack_fs::SyncReadableFileSystem;
 use rspack_paths::Utf8PathBuf;
 use rustc_hash::FxHashSet as HashSet;
 
@@ -25,14 +25,14 @@ pub struct Snapshot {
   // 1. update compiler.input_file_system to async file system
   // 2. update this fs to AsyncReadableFileSystem
   // 3. update add/calc_modified_files to async fn
-  fs: Arc<dyn ReadableFileSystem>,
+  fs: Arc<dyn SyncReadableFileSystem>,
   storage: Arc<dyn Storage>,
 }
 
 impl Snapshot {
   pub fn new(
     options: SnapshotOptions,
-    fs: Arc<dyn ReadableFileSystem>,
+    fs: Arc<dyn SyncReadableFileSystem>,
     storage: Arc<dyn Storage>,
   ) -> Self {
     Self {
@@ -107,7 +107,7 @@ impl Snapshot {
 mod tests {
   use std::sync::Arc;
 
-  use rspack_fs::{MemoryFileSystem, WritableFileSystem};
+  use rspack_fs::{MemoryFileSystem, SyncWritableFileSystem};
   use rspack_paths::Utf8PathBuf;
 
   use super::super::MemoryStorage;

crates/rspack_core/src/cache/persistent/snapshot/strategy.rs

@@ -4,7 +4,7 @@ use std::{
 };
 
 use rspack_cacheable::cacheable;
-use rspack_fs::ReadableFileSystem;
+use rspack_fs::SyncReadableFileSystem;
 use rspack_paths::Utf8PathBuf;
 use rustc_hash::FxHashMap as HashMap;
 
@@ -36,12 +36,12 @@ pub enum ValidateResult {
 }
 
 pub struct StrategyHelper {
-  fs: Arc<dyn ReadableFileSystem>,
+  fs: Arc<dyn SyncReadableFileSystem>,
   package_version_cache: HashMap<Utf8PathBuf, Option<String>>,
 }
 
 impl StrategyHelper {
-  pub fn new(fs: Arc<dyn ReadableFileSystem>) -> Self {
+  pub fn new(fs: Arc<dyn SyncReadableFileSystem>) -> Self {
     Self {
       fs,
       package_version_cache: Default::default(),
@@ -132,7 +132,7 @@ impl StrategyHelper {
 mod tests {
   use std::sync::Arc;
 
-  use rspack_fs::{MemoryFileSystem, ReadableFileSystem, WritableFileSystem};
+  use rspack_fs::{MemoryFileSystem, SyncReadableFileSystem, SyncWritableFileSystem};
 
   use super::{Strategy, StrategyHelper, ValidateResult};
 

crates/rspack_core/src/compiler/compilation.rs

@@ -14,7 +14,7 @@ use rspack_collections::{
   DatabaseItem, Identifiable, IdentifierDashMap, IdentifierMap, IdentifierSet, UkeyMap, UkeySet,
 };
 use rspack_error::{error, miette::diagnostic, Diagnostic, DiagnosticExt, Result, Severity};
-use rspack_fs::ReadableFileSystem;
+use rspack_fs::SyncReadableFileSystem;
 use rspack_futures::FuturesResults;
 use rspack_hash::{RspackHash, RspackHashDigest};
 use rspack_hook::define_hook;
@@ -201,7 +201,7 @@ pub struct Compilation {
   pub modified_files: HashSet<PathBuf>,
   pub removed_files: HashSet<PathBuf>,
   make_artifact: MakeArtifact,
-  pub input_filesystem: Arc<dyn ReadableFileSystem>,
+  pub input_filesystem: Arc<dyn SyncReadableFileSystem>,
 }
 
 impl Compilation {
@@ -238,7 +238,7 @@ impl Compilation {
     module_executor: Option<ModuleExecutor>,
     modified_files: HashSet<PathBuf>,
     removed_files: HashSet<PathBuf>,
-    input_filesystem: Arc<dyn ReadableFileSystem>,
+    input_filesystem: Arc<dyn SyncReadableFileSystem>,
   ) -> Self {
     let incremental = Incremental::new(options.experiments.incremental);
     Self {

crates/rspack_core/src/compiler/make/repair/build.rs

@@ -1,7 +1,7 @@
 use std::{collections::VecDeque, sync::Arc};
 
 use rspack_error::{Diagnostic, IntoTWithDiagnosticArray};
-use rspack_fs::ReadableFileSystem;
+use rspack_fs::SyncReadableFileSystem;
 
 use super::{process_dependencies::ProcessDependenciesTask, MakeTaskContext};
 use crate::{
@@ -18,7 +18,7 @@ pub struct BuildTask {
   pub resolver_factory: Arc<ResolverFactory>,
   pub compiler_options: Arc<CompilerOptions>,
   pub plugin_driver: SharedPluginDriver,
-  pub fs: Arc<dyn ReadableFileSystem>,
+  pub fs: Arc<dyn SyncReadableFileSystem>,
 }
 
 #[async_trait::async_trait]

crates/rspack_core/src/compiler/make/repair/mod.rs

@@ -6,7 +6,7 @@ pub mod process_dependencies;
 use std::sync::Arc;
 
 use rspack_error::Result;
-use rspack_fs::ReadableFileSystem;
+use rspack_fs::SyncReadableFileSystem;
 use rustc_hash::{FxHashMap as HashMap, FxHashSet as HashSet};
 
 use super::MakeArtifact;
@@ -24,7 +24,7 @@ pub struct MakeTaskContext {
   pub compilation_id: CompilationId,
   pub plugin_driver: SharedPluginDriver,
   pub buildtime_plugin_driver: SharedPluginDriver,
-  pub fs: Arc<dyn ReadableFileSystem>,
+  pub fs: Arc<dyn SyncReadableFileSystem>,
   pub compiler_options: Arc<CompilerOptions>,
   pub resolver_factory: Arc<ResolverFactory>,
   pub loader_resolver_factory: Arc<ResolverFactory>,

crates/rspack_core/src/compiler/mod.rs

@@ -5,7 +5,7 @@ mod module_executor;
 use std::sync::Arc;
 
 use rspack_error::Result;
-use rspack_fs::{AsyncWritableFileSystem, NativeFileSystem, ReadableFileSystem};
+use rspack_fs::{AsyncWritableFileSystem, NativeFileSystem, SyncReadableFileSystem};
 use rspack_futures::FuturesResults;
 use rspack_hook::define_hook;
 use rspack_paths::{Utf8Path, Utf8PathBuf};
@@ -54,7 +54,7 @@ pub struct CompilerHooks {
 pub struct Compiler {
   pub options: Arc<CompilerOptions>,
   pub output_filesystem: Box<dyn AsyncWritableFileSystem + Send + Sync>,
-  pub input_filesystem: Arc<dyn ReadableFileSystem>,
+  pub input_filesystem: Arc<dyn SyncReadableFileSystem>,
   pub compilation: Compilation,
   pub plugin_driver: SharedPluginDriver,
   pub buildtime_plugin_driver: SharedPluginDriver,
@@ -75,7 +75,7 @@ impl Compiler {
     buildtime_plugins: Vec<BoxPlugin>,
     output_filesystem: Option<Box<dyn AsyncWritableFileSystem + Send + Sync>>,
     // only supports passing input_filesystem in rust api, no support for js api
-    input_filesystem: Option<Arc<dyn ReadableFileSystem + Send + Sync>>,
+    input_filesystem: Option<Arc<dyn SyncReadableFileSystem + Send + Sync>>,
     // no need to pass resolve_factory in rust api
     resolver_factory: Option<Arc<ResolverFactory>>,
     loader_resolver_factory: Option<Arc<ResolverFactory>>,

crates/rspack_core/src/module.rs

@@ -8,7 +8,7 @@ use async_trait::async_trait;
 use json::JsonValue;
 use rspack_collections::{Identifiable, Identifier, IdentifierSet};
 use rspack_error::{Diagnosable, Diagnostic, Result};
-use rspack_fs::ReadableFileSystem;
+use rspack_fs::SyncReadableFileSystem;
 use rspack_hash::RspackHashDigest;
 use rspack_sources::Source;
 use rspack_util::atom::Atom;
@@ -32,7 +32,7 @@ pub struct BuildContext {
   pub compiler_options: Arc<CompilerOptions>,
   pub resolver_factory: Arc<ResolverFactory>,
   pub plugin_driver: SharedPluginDriver,
-  pub fs: Arc<dyn ReadableFileSystem>,
+  pub fs: Arc<dyn SyncReadableFileSystem>,
 }
 
 #[derive(Debug, Clone, Hash, PartialEq, Eq)]

crates/rspack_core/src/resolver/boxfs.rs

@@ -1,14 +1,14 @@
 use std::{io, sync::Arc};
 
-use rspack_fs::{Error, ReadableFileSystem};
+use rspack_fs::{Error, SyncReadableFileSystem};
 use rspack_paths::AssertUtf8;
 use rspack_resolver::{FileMetadata, FileSystem as ResolverFileSystem};
 
 #[derive(Clone)]
-pub struct BoxFS(Arc<dyn ReadableFileSystem>);
+pub struct BoxFS(Arc<dyn SyncReadableFileSystem>);
 
 impl BoxFS {
-  pub fn new(fs: Arc<dyn ReadableFileSystem>) -> Self {
+  pub fn new(fs: Arc<dyn SyncReadableFileSystem>) -> Self {
     Self(fs)
   }
 }

crates/rspack_core/src/resolver/factory.rs

@@ -1,7 +1,7 @@
 use std::{hash::BuildHasherDefault, sync::Arc};
 
 use dashmap::DashMap;
-use rspack_fs::ReadableFileSystem;
+use rspack_fs::SyncReadableFileSystem;
 use rustc_hash::FxHasher;
 
 use super::resolver_impl::Resolver;
@@ -29,7 +29,7 @@ impl ResolverFactory {
     self.resolver.clear_cache();
   }
 
-  pub fn new(options: Resolve, fs: Arc<dyn ReadableFileSystem>) -> Self {
+  pub fn new(options: Resolve, fs: Arc<dyn SyncReadableFileSystem>) -> Self {
     Self {
       base_options: options.clone(),
       resolver: Resolver::new(options, fs),

crates/rspack_core/src/resolver/resolver_impl.rs

@@ -8,7 +8,7 @@ use rspack_error::{
   miette::{diagnostic, Diagnostic},
   DiagnosticExt, Severity, TraceableError,
 };
-use rspack_fs::ReadableFileSystem;
+use rspack_fs::SyncReadableFileSystem;
 use rspack_loader_runner::DescriptionData;
 use rspack_paths::AssertUtf8;
 use rustc_hash::FxHashSet as HashSet;
@@ -83,11 +83,11 @@ pub struct Resolver {
 }
 
 impl Resolver {
-  pub fn new(options: Resolve, fs: Arc<dyn ReadableFileSystem>) -> Self {
+  pub fn new(options: Resolve, fs: Arc<dyn SyncReadableFileSystem>) -> Self {
     Self::new_rspack_resolver(options, fs)
   }
 
-  fn new_rspack_resolver(options: Resolve, fs: Arc<dyn ReadableFileSystem>) -> Self {
+  fn new_rspack_resolver(options: Resolve, fs: Arc<dyn SyncReadableFileSystem>) -> Self {
     let options = to_rspack_resolver_options(options, false, DependencyCategory::Unknown);
     let boxfs = BoxFS::new(fs);
     let resolver = rspack_resolver::ResolverGeneric::new_with_file_system(boxfs, options);

crates/rspack_fs/src/lib.rs

@@ -2,7 +2,7 @@ mod r#async;
 pub use r#async::{AsyncFileSystem, AsyncReadableFileSystem, AsyncWritableFileSystem};
 
 mod sync;
-pub use sync::{FileSystem, ReadableFileSystem, WritableFileSystem};
+pub use sync::{SyncFileSystem, SyncReadableFileSystem, SyncWritableFileSystem};
 
 mod file_metadata;
 pub use file_metadata::FileMetadata;