chore(clippy): no unwrap in result function

[h-a-n-a]

New rule added:

• unwrap_in_result (see: https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_in_result)

For those who curious about solving lint issues:

1. how to deal with Result: use anyhow as Result, and for those errors that implements Error, anyhow would convert it to anyhow::Error

struct MyError {}

impl Error for MyError {} // implementing `Error` trait from std

fn () -> anyhow::Result<()> { // basically a wrapper around std Result, with `anyhow::Error` set to the error section 
   some_function()?; // this function would return `Result<(), MyError>`, since the error implements Error trait, anyhow could utilize this to convert it directly

   // you can also provide the context to `anyhow`
   some_function().context("more informations about this error can be stated here")?; // it's the identical function as above.
}

// also, map_err is available for those error types that don't implement std Error

some_result.map_err(|e| { 
  // you may convert it to your own error type, or use `anyhow::anyhow!()` to create an anyhow Error type.
})

2. how to deal with Option

some_option_type.ok_or_else(|e| {  
   // you can convert the error here like above.
})

For more information, you may checkout the doc provided by anyhow: https://docs.rs/anyhow/latest/anyhow/

More information about rust-clippy

Clippy is not currently supporting workspace lint rules, according to EmbarkStudios/rust-ecosystem#68, this can be achieved by adding rustflags to compiler.

[IWANABETHATGUY]

What about Option unwrap, which may also raise a panic

[h-a-n-a]

Rspack Benchmark Result

Fixture

Cold start(Decrease detected ✓)

Arco Design

Metric	Main	Pull Request	Diff
Cold Start Diff	11.9s	11.8s	-54ms

[h-a-n-a]

What about Option unwrap, which may also raise a panic

If Option exists in a function that returns Result, you can use ok_or_else to map None to anyhow::Error, and clippy will complain if you call unwrap() on Option directly in this function