Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename FileSystem to SyncFileSystem #8520

Merged
merged 1 commit into from
Nov 25, 2024
Merged

refactor: rename FileSystem to SyncFileSystem #8520

merged 1 commit into from
Nov 25, 2024
+138 −134

Conversation

hardfist
Copy link
Contributor

Summary

rename FileSystem to SyncFileSystem since we plan to introduce FileSystem as SyncFileSystem + AsyncFileSystem

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 25, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 8f7cd59
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/674417480ab6fe0008c2acaf

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #8520 will not alter performance

Comparing yj/refactor-fs (8f7cd59) with main (4f66057)

Summary

✅ 1 untouched benchmarks

@hardfist hardfist merged commit eb12150 into main Nov 25, 2024
37 checks passed
@hardfist hardfist deleted the yj/refactor-fs branch November 25, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz jerrykingxyz is a code owner

Assignees

@hardfist hardfist

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardfist @LingyuCoder