Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP chore: remove server data parse in convention routes #6651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zllkjc
Copy link
Member

@zllkjc zllkjc commented Dec 20, 2024

Summary

In the past, we supported server routing dynamic parameters:

{
  server: {
    routes: {
      main: "/:id"
    }
  }
}

Then user can get the params from useRuntimeContext().context.params, and it will inject a script into the HTML

But this feature is not compatible with conventional routing, the script will be parsed in router runtime plugin and cause conventional routing render error. In this PR, we remove the logic in route runtime plugin.

Now the user can still use this features in self-control route.

Related Links

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: af76f9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for modernjs-byted ready!

Name Link
🔨 Latest commit af76f9e
🔍 Latest deploy log https://app.netlify.com/sites/modernjs-byted/deploys/676540e488a8ad0007ce9f90
😎 Deploy Preview https://deploy-preview-6651--modernjs-byted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🟢 up 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@zllkjc zllkjc changed the title chore: remove server data parse in convention routes WIP chore: remove server data parse in convention routes Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant