Skip to content

Add ability to template ServiceMonitor labels and add metrics port to Service (#192 & #121) #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jfcmartins wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add ability to template ServiceMonitor labels and add metrics port to Service (#192 & #121) #197

jfcmartins wants to merge 4 commits into from

Conversation

@jfcmartins
Copy link

@jfcmartins jfcmartins commented Dec 11, 2023 •
edited
Loading

Changes

@jfcmartins jfcmartins changed the title Add ability to template ServiceMonitor labels and add metrics port to Service (#192 & #121= Add ability to template ServiceMonitor labels and add metrics port to Service (#192 & #121) Dec 11, 2023
@weaviate-git-bot
Copy link

weaviate-git-bot commented Dec 12, 2023

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@jfcmartins
Copy link
Author

jfcmartins commented Dec 12, 2023

I agree with the CLA

@jfcmartins jfcmartins force-pushed the 192-121-metrics-support branch from 2f3abb7 to f6f323b Compare December 13, 2023 18:17
@jfcmartins jfcmartins mentioned this pull request Dec 19, 2023
Closed
@ohamadeh
Copy link

ohamadeh commented Sep 22, 2025 •
edited
Loading

Hey guys I was about to open a PR for the same issue. Is there an estimated timeline of when can this be merged/released?

Edit: I guess the chart version needs to be corrected and conflicts resolved because this is an old PR. If needed I can redo the same changes in a fresh PR

mahai71
mahai71 suggested changes Oct 31, 2025
View reviewed changes
Copy link

@mahai71 mahai71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have same issue and need to solve it

orca-security-eu[bot]
orca-security-eu bot reviewed Nov 1, 2025
View reviewed changes
Copy link

@orca-security-eu orca-security-eu bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@jfcmartins jfcmartins force-pushed the 192-121-metrics-support branch from 926b211 to e1bc492 Compare November 1, 2025 11:56
@jfcmartins
Copy link
Author

jfcmartins commented Nov 1, 2025 •
edited
Loading

Hey guys I was about to open a PR for the same issue. Is there an estimated timeline of when can this be merged/released?

Edit: I guess the chart version needs to be corrected and conflicts resolved because this is an old PR. If needed I can redo the same changes in a fresh PR

PR fixed @ohamadeh ✔️

mahai71
mahai71 suggested changes Nov 3, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orca-security-eu orca-security-eu[bot] orca-security-eu[bot] left review comments

@haarisedhi102 haarisedhi102 Awaiting requested review from haarisedhi102

+2 more reviewers

@ohamadeh ohamadeh ohamadeh left review comments

@mahai71 mahai71 mahai71 requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jfcmartins @weaviate-git-bot @ohamadeh @haarisedhi102 @mahai71