Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to mui 5 #4296

Merged
merged 9 commits into from
Dec 29, 2024
Merged

chore(deps): upgrade to mui 5 #4296

merged 9 commits into from
Dec 29, 2024

Conversation

tenstad
Copy link
Contributor

@tenstad tenstad commented Dec 29, 2024

https://mui.com/material-ui/migration/migration-v4/
https://mui.com/material-ui/migration/v5-style-changes/

What changed?
material ui from 4 to 5

Seems a bit strange that the snapshots contains values such as css-bf3zdk-MuiTableCell-root (bf3zdk not in v4), but might just be how it is in v5.

Why was this change made?

Had to merge colorSecondary into root of MuiRadio to fix colors here (should have been blueish). Similar for checkbox which turned black after upgrade to v5.
image

Removed the min-width: 300 to fix this one:
image

These style changes were done in e3dc5fb (the $ -> .Mui- was part of the 4 -> 5 upgrade).

How was this change implemented?

How did you validate the change?

Clicked around in the GUI after running tilt up with a cluster having some Flux Kustomizations.

Release notes

Documentation Changes

@tenstad tenstad force-pushed the mui branch 2 times, most recently from c806440 to 8b4cdf9 Compare December 29, 2024 10:27
@tenstad tenstad marked this pull request as ready for review December 29, 2024 11:09
@tenstad tenstad marked this pull request as draft December 29, 2024 14:13
@tenstad tenstad force-pushed the mui branch 2 times, most recently from b41fefe to a0fce82 Compare December 29, 2024 17:15
@tenstad tenstad marked this pull request as ready for review December 29, 2024 17:35
@casibbald casibbald enabled auto-merge (squash) December 29, 2024 17:37
@casibbald casibbald merged commit 2e4f4ab into weaveworks:main Dec 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants