Fix the vulnerability in the yaml NPM package
#3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
force-pushed
the
3637-fix-yaml-vulnerability
branch
from
71f4c06 to
20f159c
Compare
…ity, reported by Snyk. Add an alias for the `yaml` package in `package.json` to resolve the ReferenceError happening in v2.2.2 with the default import. Update the `@docusaurus` package and its dependencies.
opudrovs
force-pushed
the
3637-fix-yaml-vulnerability
branch
from
20f159c to
809dd09
Compare
|
Great PR description btw 👌 |
|
@foot thank you! 🌞 |
This was referenced Apr 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3637
Upgraded the
yamlpackage to version 2.2.2 to resolve the vulnerability, reported by Snyk.Added an alias for the
yamlpackage inpackage.jsonto resolve the ReferenceError happening in v2.2.2 with the default import. Parcel chokes on mixed types of exports (probably where export all/export with rename are mixed, as stated in the following issue $78fb23f46eb09f80$exports is not defined parcel-bundler/parcel#8792 ).Updated the
@docusauruspackage and its dependencies. Added a custom resolution foryamlv2.2.2 to website subdependencies.Tested:
npm run buildto make sure it builds successfully.yarn start.Testing:
To test it, run the app in Tilt and make sure that there are no errors displayed in the browser console in general or on object detail pages when displaying YAML views.