Skip to content

Commit

Permalink
chore: node 22 (#4290)
Browse files Browse the repository at this point in the history
* chore: node 22
  • Loading branch information
tenstad authored Dec 29, 2024
1 parent 023a989 commit 4dd3742
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 9 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.X]
node-version: [22.x]
steps:
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
- name: Node modules cache
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
strategy:
matrix:
go-version: [1.23.X]
node-version: [16.X]
node-version: [22.x]
steps:
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
- name: Setup Go
Expand Down Expand Up @@ -232,7 +232,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version: "16.X"
node-version: "22.x"
registry-url: "https://npm.pkg.github.com"
scope: "@weaveworks"
- run: yarn
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prepare-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version: 16.X
node-version: 22.x
- name: Set up environment vars
run: |
echo "BRANCH=releases/${{ github.event.inputs.version }}" >> $GITHUB_ENV
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
ref: ${{ github.event.pull_request.head.sha }}
- uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version: "16.X"
node-version: "22.x"
registry-url: "https://npm.pkg.github.com"
scope: "@weaveworks"
- run: yarn
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version: 16.X
node-version: 22.x
- name: Set env var
env:
GITHUB_EVENT_PULL_REQUEST_HEAD_REF: ${{ github.event.pull_request.head.ref }}
Expand Down
2 changes: 1 addition & 1 deletion doc/development-process.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Step one, make sure you've installed the tools listed at the very top of this fi

Step two, now you **must** **ALSO** have the following installed.

- [node](https://nodejs.org/en/) v16 - Install Node.js
- [node](https://nodejs.org/en/) v22 - Install Node.js

Now you have those things installed, lets go!

Expand Down
2 changes: 1 addition & 1 deletion gitops-server.dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# UI build
FROM node:16-bullseye@sha256:cd59a61258b82b86c1ff0ead50c8a689f6c3483c5ed21036e11ee741add419eb AS ui
FROM node:22-bookworm@sha256:0e910f435308c36ea60b4cfd7b80208044d77a074d16b768a81901ce938a62dc AS ui
RUN apt-get update -y && apt-get install -y build-essential
RUN mkdir -p /home/app && chown -R node:node /home/app
WORKDIR /home/app
Expand Down
8 changes: 7 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
"distDir": "bin/dist",
"source": "ui/index.html",
"sourceMap": false,
"publicUrl": "./"
"publicUrl": "./",
"engines": {
"browsers": "> 0.5%, last 2 versions, not dead"
}
},
"lib": {
"includeNodeModules": false,
Expand Down Expand Up @@ -134,5 +137,8 @@
"jest": "^29.0.0",
"cross-spawn": "^7.0.5",
"commander": "^11.0.0"
},
"engines": {
"node": ">=22.0"
}
}

0 comments on commit 4dd3742

Please sign in to comment.