Skip to content

Turn on react / react-hook eslinters to ensure consistency with EE #8645

Turn on react / react-hook eslinters to ensure consistency with EE

Turn on react / react-hook eslinters to ensure consistency with EE #8645

Triggered via pull request December 28, 2023 16:54
Status Failure
Total duration 4m 38s
Artifacts 2

pr.yaml

on: pull_request
Matrix: CI Test JS
Matrix: CI Test Go
Matrix: CI Check Static Checks
CI Generate Image Tag
0s
CI Generate Image Tag
release
2s
release
Publish js library
0s
Publish js library
Matrix: CI Build Gitops Docker Image
Matrix: CI Upload Images
Matrix: Upload Binary
PR CI Pipeline
0s
PR CI Pipeline
PR CI Pipeline
0s
PR CI Pipeline
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 11 warnings
CI Test JS (16.X): ui/components/DagGraph.tsx#L154
Invalid property 'fill' found on tag 'foreignObject', but it is only allowed on: altGlyph, circle, ellipse, g, line, marker, mask, path, polygon, polyline, rect, svg, symbol, text, textPath, tref, tspan, use, animate, animateColor, animateMotion, animateTransform, set
CI Test JS (16.X): ui/components/DependenciesView.tsx#L34
React Hook "useListObjects" is called conditionally. React Hooks must be called in the exact same order in every component render
CI Test JS (16.X): ui/components/DependenciesView.tsx#L104
`'` can be escaped with `'`, `‘`, `'`, `’`
CI Test JS (16.X): ui/components/DependenciesView.tsx#L104
`'` can be escaped with `'`, `‘`, `'`, `’`
CI Test JS (16.X): ui/components/DirectedGraph.tsx#L77
Invalid property 'fill' found on tag 'foreignObject', but it is only allowed on: altGlyph, circle, ellipse, g, line, marker, mask, path, polygon, polyline, rect, svg, symbol, text, textPath, tref, tspan, use, animate, animateColor, animateMotion, animateTransform, set
CI Test JS (16.X): ui/components/ImageAutomation/updates/ImageAutomationUpdatesDetails.tsx#L31
React Hook "useFeatureFlags" is called in function "getInfoList" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"
CI Test JS (16.X): ui/components/Sync/CheckboxActions.tsx#L40
React Hook "useToggleSuspend" is called in function "createSuspendHandler" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"
CI Test JS (16.X): ui/components/Sync/SuspendMessageModal.tsx#L74
Do not pass children as props. Instead, nest children between the opening and closing tags
CI Test JS (16.X): ui/components/YamlView.tsx#L34
React Hook "useInDarkMode" is called conditionally. React Hooks must be called in the exact same order in every component render
CI Test JS (16.X): ui/contexts/AuthContext.tsx#L29
React Hook "useLocation" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?
CI Generate Image Tag
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
CI Test JS (16.X): ui/components/DependenciesView.tsx#L62
React Hook React.useEffect has a missing dependency: 'automation'. Either include it or remove the dependency array
CI Test JS (16.X): ui/components/ErrorBoundary.tsx#L57
React Hook useEffect has a missing dependency: 'hasError'. Either include it or remove the dependency array
CI Test JS (16.X): ui/components/Form.tsx#L48
React Hook React.useEffect has a missing dependency: 'onChange'. Either include it or remove the dependency array. If 'onChange' changes too often, find the parent component that defines it and wrap that definition in useCallback
CI Test JS (16.X): ui/components/PendoContainer.tsx#L35
React Hook React.useEffect has a missing dependency: 'data'. Either include it or remove the dependency array
CI Test JS (16.X): ui/contexts/AppContext.tsx#L74
React Hook React.useEffect has a missing dependency: 'clearAsyncError'. Either include it or remove the dependency array. Outer scope values like 'window.location' aren't valid dependencies because mutating them doesn't re-render the component
CI Test JS (16.X): ui/contexts/AuthContext.tsx#L85
React Hook React.useCallback has missing dependencies: 'getUserInfo', 'history', and 'request'. Either include them or remove the dependency array
CI Test JS (16.X): ui/contexts/AuthContext.tsx#L102
React Hook React.useCallback has a missing dependency: 'request'. Either include it or remove the dependency array
CI Test JS (16.X): ui/contexts/AuthContext.tsx#L117
React Hook React.useCallback has a missing dependency: 'request'. Either include it or remove the dependency array
CI Test JS (16.X): ui/hooks/__tests__/common.test.tsx#L28
React Hook React.useEffect has a missing dependency: 'req'. Either include it or remove the dependency array
CI Test JS (16.X): ui/hooks/__tests__/common.test.tsx#L51
React Hook React.useEffect has a missing dependency: 'req'. Either include it or remove the dependency array

Artifacts

Produced during runtime
Name Size
gitops Expired
53 MB
gitops-server Expired
40.2 MB