This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Fixes issue 270: footloose container fails to start after upgrading t… #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o Docker 4.3 According to https://docs.docker.com/desktop/mac/release-notes/#bug-fixes-and-minor-changes-1 - Add the following option: --cgroupns=host - Modifies volume option: -v /sys/fs/cgroup:/sys/fs/cgroup:rw. Adds a debian11 image that uses systemd 247
jnummelin
reviewed
Feb 4, 2022
Comment on lines
+297
to
+298
| "--cgroupns", "host", | ||
| "-v", "/sys/fs/cgroup:/sys/fs/cgroup:rw", |
There was a problem hiding this comment.
I think this needs to be a conditional setup as not all systems using footloose will have cgroups v2 in place. Or at least it needs to be made sure this does not break cgroups v1 based setups of docker. E.g. we (https://github.com/k0sproject/k0s) use footloose heavily without Docker Desktop e.g. in our CI where the runners are cgroups v1 based.
|
I created a PR which conditionally adds support for cgroupv2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o Docker 4.3
According to https://docs.docker.com/desktop/mac/release-notes/#bug-fixes-and-minor-changes-1
--cgroupns=host
-v /sys/fs/cgroup:/sys/fs/cgroup:rw.
Adds a debian11 image that uses systemd 247