Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Fix footloose ssh for Ignite VMs #247

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Jun 9, 2020

Fetch the port configuration from Ignite itself now that it uses containerd as the default backend. This is kind of a "quick fix" refined version of #229 from quite some time ago, ultimately we do want to separate the Ignite and Docker backends completely to keep the code readable/maintainable (#220).

Fixes #228.

Signed-off-by: Dennis Marttinen <[email protected]>
@twelho twelho requested a review from luxas June 9, 2020 09:02
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. We'll see later if/how to make this code better holistically.

@luxas luxas self-assigned this Jun 9, 2020
@luxas luxas merged commit 8f3df89 into weaveworks:master Jun 9, 2020
@twelho twelho deleted the fix-ssh branch June 16, 2020 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'failed to inspect container error' while trying to ssh into containers using ignite
2 participants