Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement light mode for the client side #11 #16

Merged
merged 5 commits into from
Jan 25, 2025

Conversation

ussyalfaks
Copy link
Contributor

No description provided.

@Samuel1-ona Samuel1-ona requested a review from Otaiki1 January 24, 2025 11:41
Copy link
Contributor

@Otaiki1 Otaiki1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi i noticed some inconsistencies in your work . The Light/dark mode only affects a certain part of the page and not the entire app . Kindly rectify this.
Try using a flexible tailwind class that makes this easier to achieve
Screenshot 2025-01-24 at 12 47 34
As observed in the top section of the image .

@ussyalfaks
Copy link
Contributor Author

Hi i noticed some inconsistencies in your work . The Light/dark mode only affects a certain part of the page and not the entire app . Kindly rectify this. Try using a flexible tailwind class that makes this easier to achieve Screenshot 2025-01-24 at 12 47 34 As observed in the top section of the image .

kk

Copy link
Contributor

@Otaiki1 Otaiki1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ussyalfaks , Your recent PR still has the previous issues . The change in color mode only affects few parts of the app

@Otaiki1 Otaiki1 requested a review from Samuel1-ona January 25, 2025 18:32
Copy link
Contributor

@Samuel1-ona Samuel1-ona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work , Everything works as it should . Could you review and fix conflicts so @Otaiki1 can merge

Copy link
Contributor

@Samuel1-ona Samuel1-ona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !!!

@Otaiki1 Otaiki1 merged commit e89b2b0 into weaver-points:main Jan 25, 2025
@Otaiki1
Copy link
Contributor

Otaiki1 commented Jan 25, 2025

closes #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants