Refactor: avoid an unnecessary runtime check in some situations

weavejester · Dec 1, 2023 · dfa8a19 · dfa8a19
1 parent 34a1656
commit dfa8a19
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/hiccup/compiler.clj b/src/hiccup/compiler.clj
@@ -346,11 +346,12 @@
                             ~(end-tag)))
           (build-string ~(str "<" tag (render-attr-map tag-attrs) ">")
                         ~@(compile-seq [attrs-sym])))
-        ;; content and ending tag (when the above code did not emit an ending tag)
-        (when (or ~(boolean (container-tag? tag content))
-                  (not (map? ~attrs-sym)))
-          (build-string ~@(compile-seq content)
-                        ~(str "</" tag ">")))))))
+        ~@(compile-seq content)
+        ;; ending tag, when the above code did not emit an ending tag
+        ~(if (boolean (container-tag? tag content))
+           (str "</" tag ">")
+           `(when-not (map? ~attrs-sym)
+              ~(str "</" tag ">")))))))
 
 (defmethod compile-element :default
   [element]