Update the dependencies in composer.json #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR still opened since 2021 and not merged yet ?!?!?!? Where are the author and the maintainers of this package? Please anyone merge this PR as it's very important. We can't upgrade to the newer PHP version because of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this package depends on quite old versions of the
symfony/dom-crawlerandsymfony/css-selectorpackages (versions ~2.8 and ~3.0). This makes the package incompatible with other packages requiring higher versions of these dependencies.I have tested and
yii2-dynamicformworks fine with the 5.x version ofsymfony/dom-crawlerandsymfony/css-selector, hence I submit this PR to update these dependencies incomposer.json.