Improve code quality and legibility #734
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to improve Golang code quality and legibility to facilitate future changes.
A non-exhaustive list of changes is:
if-else
withswitch-case
strings.Index()
checks withstrings.Contains()
strings.HasSuffix() + Trim
with non-conditionalstrings.TrimSuffix()
var <name> <type>
instead of<name> := <type>(zero value)
fmt.Sprintf()
on non-formatting stringsx = x + y
=>x += y
string(r.Bytes())
withr.String()
in *bytes.Buffer instances.go fmt
POST
=>http.MethodPost
and200
=>http.StatusOK
(there are still many repeated strings that could become consts)append(slice, newSlice...)
instead of a for loopregex.MustCompile
== true
andif cond == true ... return true ... else return false
There are still many improvements to be made, but this PR was already too big so I'll make separate PRs after this one (hopefully) gets merged.
@esimkowitz I need help testing this. It shouldn't change anything (besides perhaps throwing some errors that were previously incorrectly ignored), but better safe than sorry.