fix terminal selection colors when transparency is turned on

[sawka]

fix some more of the selection background colors and fix onedarkpro (was too washed out and not using the correct official colors)

[coderabbitai]

Walkthrough

The pull request introduces modifications to the termthemes.json configuration file, which manages color themes for terminal interfaces. The changes primarily focus on color palette adjustments across multiple themes, including "onedarkpro", "dracula", "monokai", "campbell", "warmyellow", and "rosepine".

In the "onedarkpro" theme, several color values are updated, including background, red, green, blue, and magenta colors. These modifications slightly alter the theme's visual appearance by tweaking specific color hex codes. The "dracula", "monokai", and "rosepine" themes see the removal of the selectionBackground color property.

The "campbell" and "warmyellow" themes experience modifications to their selectionBackground color, with the hex codes being updated to include an alpha channel (77 suffix), which likely introduces a slight transparency effect.

These changes represent fine-tuning of the color configurations, potentially to improve visual consistency, readability, or aesthetic appeal across different terminal themes. The modifications are confined to color value adjustments and do not involve structural changes to the configuration file's overall format or layout.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 133d7ce and 28cedae.

📒 Files selected for processing (1)

• pkg/wconfig/defaultconfig/termthemes.json (3 hunks)

🔇 Additional comments (3)

pkg/wconfig/defaultconfig/termthemes.json (3)

31-31: LGTM: Colors now match official One Dark Pro theme

The updated colors accurately reflect the official One Dark Pro theme palette, improving visual consistency.

Also applies to: 35-36, 38-39

---

125-125: LGTM: Appropriate transparency added to selection background

The addition of 47% opacity (77 in hex) to the selection background provides good visibility while supporting terminal transparency.

---

150-150: LGTM: Consistent transparency treatment for selection background

The change maintains theme consistency while adding appropriate transparency.

Please verify the visual appearance of the selection with this color in high-contrast scenarios:

✅ Verification successful

Selection background color change looks good and doesn't conflict with other themes

The verification confirms that the warm yellow selection background color #B7950B77 is unique to this theme and doesn't conflict with any other color definitions in the codebase. The 47% opacity treatment aligns with the established pattern in other themes.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if there are any other files containing color definitions that might conflict
rg -g '!termthemes.json' '#B7950B' .

Length of output: 38

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.