Feature/auto hide tab bar #1527
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ import { deleteLayoutModelForTab } from "@/layout/index"; | |
| import { atoms, createTab, getApi, globalStore, isDev, PLATFORM, setActiveTab } from "@/store/global"; | ||
| import { fireAndForget } from "@/util/util"; | ||
| import { useAtomValue } from "jotai"; | ||
| import clsx from "clsx"; | ||
| import { OverlayScrollbars } from "overlayscrollbars"; | ||
| import { createRef, memo, useCallback, useEffect, useRef, useState } from "react"; | ||
| import { debounce } from "throttle-debounce"; | ||
|
|
@@ -174,10 +175,44 @@ const TabBar = memo(({ workspace }: TabBarProps) => { | |
| const isFullScreen = useAtomValue(atoms.isFullScreen); | ||
|
|
||
| const settings = useAtomValue(atoms.settingsAtom); | ||
| const autoHideTabBar = settings?.["window:autohidetabbar"] ?? false; | ||
|
|
||
| let prevDelta: number; | ||
| let prevDragDirection: string; | ||
|
|
||
| const handleAutoHideTabBar = (event: MouseEvent) => { | ||
| const tabBar = tabbarWrapperRef.current; | ||
| const tabBarHeight = tabBar?.clientHeight + 1; | ||
|
|
||
| if (event.type === 'mouseenter') { | ||
| tabBar.style.top = '0px'; | ||
| tabBar.addEventListener("mouseleave", handleAutoHideTabBar); | ||
| tabBar.classList.add('tab-bar-wrapper-auto-hide-visible') | ||
| } | ||
|
|
||
| if (event.type === 'mouseleave') { | ||
| tabBar.style.top = `-${tabBarHeight - 10}px`; | ||
| tabBar.removeEventListener("mouseleave", handleAutoHideTabBar); | ||
| tabBar.classList.remove('tab-bar-wrapper-auto-hide-visible') | ||
| } | ||
| }; | ||
|
Comment on lines
+183
to
+198
There was a problem hiding this comment. 🛠️ Refactor suggestion Refactor to use CSS transforms instead of direct style manipulation. The current implementation uses direct style manipulation which can cause unnecessary reflows. Consider using CSS transforms for better performance. Apply this diff to use CSS transforms: const handleAutoHideTabBar = (event: MouseEvent) => {
const tabBar = tabbarWrapperRef.current;
- const tabBarHeight = tabBar?.clientHeight + 1;
if (event.type === 'mouseenter') {
- tabBar.style.top = '0px';
- tabBar.addEventListener("mouseleave", handleAutoHideTabBar);
tabBar.classList.add('tab-bar-wrapper-auto-hide-visible')
}
if (event.type === 'mouseleave') {
- tabBar.style.top = `-${tabBarHeight - 10}px`;
- tabBar.removeEventListener("mouseleave", handleAutoHideTabBar);
tabBar.classList.remove('tab-bar-wrapper-auto-hide-visible')
}
};Add these CSS classes to your stylesheet: .tab-bar-wrapper-auto-hide {
transform: translateY(-100%);
transition: transform 0.2s ease;
}
.tab-bar-wrapper-auto-hide-visible {
transform: translateY(0);
}There was a problem hiding this comment. this is a good suggestion @rritik772 There was a problem hiding this comment.
|
||
|
|
||
| useEffect(() => { | ||
| const tabBar = tabbarWrapperRef.current; | ||
| if (!autoHideTabBar) { | ||
| tabBar.style.top = '0px'; | ||
| return; | ||
| } | ||
|
|
||
| const tabBarHeight = tabBar?.clientHeight + 1; | ||
| if (autoHideTabBar) { | ||
| tabbarWrapperRef.current.style.top = `-${tabBarHeight - 10}px` | ||
| } | ||
|
|
||
| tabbarWrapperRef.current.addEventListener("mouseenter", handleAutoHideTabBar); | ||
| return () => tabbarWrapperRef.current.removeEventListener("mouseenter", handleAutoHideTabBar); | ||
| }, [autoHideTabBar]) | ||
|
Comment on lines
+200
to
+214
There was a problem hiding this comment. 🛠️ Refactor suggestion Improve event listener management. The current implementation could lead to memory leaks if the component unmounts while listeners are still attached. Also, the cleanup function might fail if Apply this diff to improve event listener management: useEffect(() => {
const tabBar = tabbarWrapperRef.current;
if (!autoHideTabBar || !tabBar) {
- tabBar.style.top = '0px';
return;
}
- const tabBarHeight = tabBar?.clientHeight + 1;
- if (autoHideTabBar) {
- tabbarWrapperRef.current.style.top = `-${tabBarHeight - 10}px`
- }
- tabbarWrapperRef.current.addEventListener("mouseenter", handleAutoHideTabBar);
+ const handleMouseEnter = (e: MouseEvent) => {
+ tabBar.classList.add('tab-bar-wrapper-auto-hide-visible');
+ tabBar.addEventListener('mouseleave', handleMouseLeave);
+ };
+ const handleMouseLeave = (e: MouseEvent) => {
+ tabBar.classList.remove('tab-bar-wrapper-auto-hide-visible');
+ tabBar.removeEventListener('mouseleave', handleMouseLeave);
+ };
+ tabBar.addEventListener("mouseenter", handleMouseEnter);
- return () => tabbarWrapperRef.current.removeEventListener("mouseenter", handleAutoHideTabBar);
+ return () => {
+ tabBar.removeEventListener("mouseenter", handleMouseEnter);
+ tabBar.removeEventListener("mouseleave", handleMouseLeave);
+ };
}, [autoHideTabBar]);
There was a problem hiding this comment. this is also a good suggestion, just in case the mouseleave handler is still attached There was a problem hiding this comment. @esimkowitz, glad to hear you find the suggestion helpful! By attaching and detaching the listeners in a more localized manner, we reduce the risk of orphaned event handlers if the component unmounts prematurely. Let me know if you need further refinements to the approach. |
||
|
|
||
| // Update refs when tabIds change | ||
| useEffect(() => { | ||
| tabRefs.current = tabIds.map((_, index) => tabRefs.current[index] || createRef()); | ||
|
|
@@ -654,7 +689,7 @@ const TabBar = memo(({ workspace }: TabBarProps) => { | |
| title: "Add Tab", | ||
| }; | ||
| return ( | ||
| <div ref={tabbarWrapperRef} className={clsx('tab-bar-wrapper', {'tab-bar-wrapper-auto-hide': autoHideTabBar, 'tab-bar-wrapper-always-visible': !autoHideTabBar})}> | ||
| <WindowDrag ref={draggerLeftRef} className="left" /> | ||
| {appMenuButton} | ||
| {devLabel} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Z-index value needs adjustment to follow established system
The z-index value of 1000 in tabbar.scss does not align with the established z-index system in theme.scss. The highest z-index value defined in the theme is 550 (for flash-error-container), and most UI components use values between 1-100. The tabbar should use a themed z-index variable that fits within this hierarchy.
z-index: 1000to use a themed variable like--zindex-tabbarthat should be defined in theme.scss with an appropriate value (likely between 100-500 based on other component values)🔗 Analysis chain
Verify z-index value in the component hierarchy
The z-index value of 1000 seems arbitrary. Please verify that this value:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 171
Script:
Length of output: 119041
Script:
Length of output: 2818
Script:
Length of output: 55
Script:
Length of output: 1103
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@esimkowitz Thank you for confirming. Let me know if there's anything else you need!