Chinese localization #691
Closed
Chinese localization #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, I screwed up the branch by using rebase when I should use merge. |
rename locale directory to zh and recopy json files to include sectionkey field
|
oh, right now only 2 character code is supported, so I changed it to zh for now |
|
I know the docs said it needs a 2-character code, but is that actually true? Does the implementation check the length of the locale code anywhere? |
|
yeah, in initLanguageFiles, it extracts the first 2 characters |
…chinese_localization
…chinese_localization
|
I hate to close this, but our strategy for localization has changed pretty radically. On the plus side, future localizations should be much easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #690.