fix(api): Make linter happy, fix typo

wasmerio · Nov 25, 2024 · 1005cfc · 1005cfc
1 parent f381470
commit 1005cfc
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 19 deletions.
diff --git a/lib/api/src/entities/engine/inner.rs b/lib/api/src/entities/engine/inner.rs
@@ -119,6 +119,7 @@ impl RuntimeEngine {
 }
 
 impl Default for RuntimeEngine {
+    #[allow(unreachable_code)]
     fn default() -> Self {
         #[cfg(feature = "sys")]
         {

diff --git a/lib/api/src/entities/engine/mod.rs b/lib/api/src/entities/engine/mod.rs
@@ -36,7 +36,7 @@ impl Default for Engine {
     fn default() -> Self {
         Self {
             rt: Default::default(),
-            id: Engine::atomic_next_engine_id(),
+            id: Self::atomic_next_engine_id(),
         }
     }
 }

diff --git a/lib/api/src/rt/js/entities/engine.rs b/lib/api/src/rt/js/entities/engine.rs
@@ -50,7 +50,7 @@ impl Into<crate::Engine> for Engine {
     fn into(self) -> crate::Engine {
         crate::Engine {
             rt: crate::RuntimeEngine::Js(self),
-            id: Engine::atomic_next_engine_id(),
+            id: crate::Engine::atomic_next_engine_id(),
         }
     }
 }
diff --git a/lib/api/src/rt/jsc/entities/engine.rs b/lib/api/src/rt/jsc/entities/engine.rs
@@ -246,7 +246,7 @@ impl Into<crate::Engine> for Engine {
     fn into(self) -> crate::Engine {
         crate::Engine {
             rt: crate::RuntimeEngine::Jsc(self),
-            id: crate::Engine::atomic_next_engine_id(),
+            id: Self::atomic_next_engine_id(),
         }
     }
 }
diff --git a/lib/api/src/rt/sys/entities/engine.rs b/lib/api/src/rt/sys/entities/engine.rs
@@ -112,16 +112,16 @@ pub trait NativeEngineExt {
 impl NativeEngineExt for crate::engine::Engine {
     #[cfg(feature = "compiler")]
     fn new(compiler_config: Box<dyn CompilerConfig>, target: Target, features: Features) -> Self {
-        crate::engine::Engine {
+        Self {
             rt: RuntimeEngine::Sys(Engine::new(compiler_config, target, features)),
-            id: crate::Engine::atomic_next_engine_id(),
+            id: Self::atomic_next_engine_id(),
         }
     }
 
     fn headless() -> Self {
-        crate::engine::Engine {
+        Self {
             rt: RuntimeEngine::Sys(Engine::headless()),
-            id: crate::Engine::atomic_next_engine_id(),
+            id: Self::atomic_next_engine_id(),
         }
     }
 
@@ -217,57 +217,57 @@ impl crate::Engine {
 
 impl From<Engine> for crate::Engine {
     fn from(value: Engine) -> Self {
-        crate::Engine {
+        Self {
             rt: RuntimeEngine::Sys(value),
-            id: crate::Engine::atomic_next_engine_id(),
+            id: Self::atomic_next_engine_id(),
         }
     }
 }
 
 impl From<&Engine> for crate::Engine {
     fn from(value: &Engine) -> Self {
-        crate::Engine {
+        Self {
             rt: RuntimeEngine::Sys(value.cloned()),
-            id: crate::Engine::atomic_next_engine_id(),
+            id: Self::atomic_next_engine_id(),
         }
     }
 }
 
 impl From<EngineBuilder> for crate::Engine {
     fn from(value: EngineBuilder) -> Self {
-        crate::Engine {
+        Self {
             rt: RuntimeEngine::Sys(value.engine()),
-            id: crate::Engine::atomic_next_engine_id(),
+            id: Self::atomic_next_engine_id(),
         }
     }
 }
 
 #[cfg(feature = "cranelift")]
 impl From<wasmer_compiler_cranelift::Cranelift> for crate::Engine {
     fn from(value: wasmer_compiler_cranelift::Cranelift) -> Self {
-        crate::Engine {
+        Self {
             rt: RuntimeEngine::Sys(value.into()),
-            id: crate::Engine::atomic_next_engine_id(),
+            id: Self::atomic_next_engine_id(),
         }
     }
 }
 
 #[cfg(feature = "singlepass")]
 impl From<wasmer_compiler_singlepass::Singlepass> for crate::Engine {
     fn from(value: wasmer_compiler_singlepass::Singlepass) -> Self {
-        crate::Engine {
+        Self {
             rt: RuntimeEngine::Sys(value.into()),
-            id: crate::Engine::atomic_next_engine_id(),
+            id: Self::atomic_next_engine_id(),
         }
     }
 }
 
 #[cfg(feature = "llvm")]
 impl From<wasmer_compiler_llvm::LLVM> for crate::Engine {
     fn from(value: wasmer_compiler_llvm::LLVM) -> Self {
-        crate::Engine {
+        Self {
             rt: RuntimeEngine::Sys(value.into()),
-            id: crate::Engine::atomic_next_engine_id(),
+            id: Self::atomic_next_engine_id(),
         }
     }
 }