Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message indicating when crate is compiled in development mode #54

Merged

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Mar 6, 2019

Refs rustwasm/rust-webpack-template#116

The wasm-pack tool builds in release mode by default, so when the wasm-pack-plugin defaults to development mode it can be confusing for uses (see rustwasm/rust-webpack-template#116).

This adds a message so that the console will clearly display when the crate is being compiled in development mode.

plugin.js Outdated Show resolved Hide resolved
Co-Authored-By: bantic <[email protected]>
Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xtuc xtuc merged commit ec51e56 into wasm-tool:master Mar 6, 2019
@xtuc
Copy link
Member

xtuc commented Mar 6, 2019

I published version 0.2.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants