-
Notifications
You must be signed in to change notification settings - Fork 7
Fix --setup file:/path/file.txt #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
When --setup is given a file which is not in the current directory, it fails with an attribute error "None has no attribute group". The cause of the issue is that the regexp failed to match the file because '/' is not present in the pattern. A solution to the problem would had been to add the / (and \ for Windows) to the pattern, but removing "file: " from "file:/path/file.py" is simpler.
|
Here's the code health analysis summary for commits Analysis Summary
|
|
First time contributing, I tried to look for unittests but it seems there are none. Also it seems to me that deepsource-io is complaining about a problem that is unrelated to this work. |
|
Btw, here is the complete traceback and steps to reproduce the problem: |
|
And then the result on my branch: |
|
Thanks, you did a great job. Seems good, will merge in the morning. Cheers! |
When --setup is given a file which is not in the current directory, it fails with an attribute error "None has no attribute group". The cause of the issue is that the regexp failed to match the file because '/' is not present in the pattern.
A solution to the problem would had been to add the / (and \ for Windows) to the pattern, but removing "file: " from "file:/path/file.py" is simpler.