Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a more specific type for BCP47 Language-Tags #44

Open
4 tasks
warriordog opened this issue Jul 20, 2023 · 0 comments
Open
4 tasks

Create a more specific type for BCP47 Language-Tags #44

warriordog opened this issue Jul 20, 2023 · 0 comments
Labels
area:code Affects or applies to the library code type:feature New feature or request

Comments

@warriordog
Copy link
Owner

Implement a type to model a BCP47 Language-Tag. These are used in NaturalLanguageString, ASLink.HRefLang, and possibly other places.

Proposed implementation:

  • Create LanguageTag utility type
    • Implicit conversion to/from string
  • Create LanguageTagConverter to convert to/from JSON
  • Change type of ASLink.HRefLang to LanguageTag

Tests will be needed for type, converter, and the modified uses.

Related to #12.
@warriordog warriordog added type:feature New feature or request area:code Affects or applies to the library code labels Jul 20, 2023
warriordog added a commit that referenced this issue Jul 20, 2023
@warriordog
chore: move TODO from ASLink to #44
4a21eb0
@warriordog warriordog mentioned this issue Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:code Affects or applies to the library code type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@warriordog