Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for content property - only contentMap works #151

Closed
warriordog opened this issue Nov 24, 2023 · 0 comments
Closed

No support for content property - only contentMap works #151

warriordog opened this issue Nov 24, 2023 · 0 comments
Assignees
@warriordog
Labels
area:code Affects or applies to the library code type:bug Something isn't working

Comments

@warriordog
Copy link
Owner

warriordog commented Nov 24, 2023 •
edited
Loading

These properties are related and should be handled together. Currently, we ignore contentMap and incorrectly handle content. It should work like this:

  • contentMap converts directly to/from ContentMap
  • content converts indirectly to/from ContentMap.DefaultValue
  • We only store one backing field - the other is just an alias.

Once resolved, then the unit test MastodonUpdateNoteActivityTest should finally work.

Depends on: #12
Relates to: #44
@warriordog warriordog added type:bug Something isn't working area:code Affects or applies to the library code labels Nov 24, 2023
@warriordog warriordog self-assigned this Nov 24, 2023
@warriordog warriordog changed the title Fix link between content and contentMap No support for content property - only contentMap works Nov 24, 2023
@warriordog warriordog added status:blocked This issue cannot be completed due to an external conflict or blocker and removed status:blocked This issue cannot be completed due to an external conflict or blocker labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warriordog warriordog

Labels
area:code Affects or applies to the library code type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@warriordog