Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): prevent issues due to bugs in earlier botocore versions #9015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tonyyli-wandb
Copy link
Contributor

@tonyyli-wandb tonyyli-wandb commented Dec 4, 2024

Description

(fixed via @amusipatla-wandb too)

Requires botocore>=1.5.76 in order to prevent errors due to the following issues:

  • I updated CHANGELOG.md, or it's not applicable

Testing

Locally, by running (and passing) system tests while artificially pinning botocore==1.5.76. Pinning botocore==1.5.75 or earlier will result in test failures due to one of the aforementioned, now-fixed issues.

Copy link
Contributor Author

tonyyli-wandb commented Dec 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/botocore-fix branch 2 times, most recently from cddaa31 to be457b2 Compare December 4, 2024 20:16
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (c6492ec) to head (9db7f54).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9015       +/-   ##
===========================================
+ Coverage   59.95%   70.04%   +10.09%     
===========================================
  Files         532      543       +11     
  Lines       57628    58003      +375     
===========================================
+ Hits        34553    40631     +6078     
+ Misses      22496    16649     -5847     
- Partials      579      723      +144     
Flag Coverage Δ
func 36.41% <ø> (?)
system 54.40% <ø> (+2.62%) ⬆️
unit 50.86% <ø> (+14.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 200 files with indirect coverage changes

@tonyyli-wandb tonyyli-wandb marked this pull request as ready for review December 4, 2024 20:26
@tonyyli-wandb tonyyli-wandb requested a review from a team as a code owner December 4, 2024 20:26
@tonyyli-wandb tonyyli-wandb enabled auto-merge (squash) December 4, 2024 20:34
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/botocore-fix branch 2 times, most recently from d002d2b to fc21e74 Compare December 12, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant