Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecated getter methods on Run and replace with properties #8925

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kptkin
Copy link
Collaborator

@kptkin kptkin commented Nov 20, 2024

Description

What does the PR do? Include a concise description of the PR contents.
For the following run methods deprecate and replace with properties.

  • deprecate get_url method use instead url property
  • deprecate get_sweep_url method use instead sweep_url property (new property)
  • deprecate get_project_url method use instead project_url property (new property)
  • deprecate project_name method use instead project property
  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 77.41935% with 14 lines in your changes missing coverage. Please review.

Project coverage is 70.03%. Comparing base (0e63403) to head (e2342eb).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
wandb/sdk/wandb_run.py 77.41% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8925      +/-   ##
==========================================
- Coverage   70.07%   70.03%   -0.05%     
==========================================
  Files         543      543              
  Lines       57825    57840      +15     
==========================================
- Hits        40523    40510      -13     
- Misses      16587    16619      +32     
+ Partials      715      711       -4     
Flag Coverage Δ
func 36.47% <19.35%> (-0.01%) ⬇️
system 54.32% <75.80%> (+0.01%) ⬆️
unit 50.86% <45.16%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
wandb/sdk/wandb_run.py 88.11% <77.41%> (+0.16%) ⬆️

... and 17 files with indirect coverage changes

@kptkin kptkin force-pushed the kpt/deprecate-run-funcs branch from 91db90a to 01d6db2 Compare November 20, 2024 21:30
@kptkin kptkin force-pushed the kpt/remove-run-obj branch from feb185b to 6ae907d Compare November 21, 2024 00:21
@kptkin kptkin force-pushed the kpt/remove-run-obj branch 4 times, most recently from 0cfc56e to 805465a Compare December 11, 2024 01:31
Base automatically changed from kpt/remove-run-obj to main December 11, 2024 01:49
@kptkin kptkin force-pushed the kpt/deprecate-run-funcs branch 3 times, most recently from 90e86b3 to e2342eb Compare December 11, 2024 19:59
@kptkin kptkin force-pushed the kpt/deprecate-run-funcs branch from e2342eb to 4663528 Compare December 13, 2024 04:17
@kptkin kptkin marked this pull request as ready for review December 13, 2024 04:19
@kptkin kptkin requested a review from a team as a code owner December 13, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant