Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Creating secret when secretName is provided #295

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Dec 18, 2024

Prevents us from trying to create a redis secret of the same name as the users provided secret.

Other changes:

  • template reference wandb.redis.passwordSecret changed to wandb.redis.secretName better reflects what the value is.
  • moves REDIS_CA_CERT to the configmap

ON HOLD until after the holidays, need to cc @flamarion for validation.

@dacbd dacbd marked this pull request as ready for review December 20, 2024 22:02
@dacbd dacbd marked this pull request as draft December 20, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant