Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prioritize app pod #225

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+14 −2
Open

fix: Prioritize app pod #225

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
048b94a
fix: Prioritize app pod
adityachoudhari26 Sep 30, 2024
cd02f09
add priority class
adityachoudhari26 Oct 1, 2024
e2be009
change name
adityachoudhari26 Oct 1, 2024
c75b3e9
conditionally create priority class
adityachoudhari26 Oct 1, 2024
57b715b
lint
adityachoudhari26 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/operator-wandb/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: operator-wandb
description: A Helm chart for deploying W&B to Kubernetes
type: application
version: 0.18.3
version: 0.18.4
appVersion: 1.0.0
icon: https://wandb.ai/logo.svg

Expand Down
1 change: 1 addition & 0 deletions charts/operator-wandb/charts/app/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,4 @@ serviceAccount:

role: {}
roleBinding: {}

2 changes: 1 addition & 1 deletion charts/operator-wandb/charts/weave/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ spec:
kind: Deployment
name: {{ include "weave.fullname" . }}
minReplicas: 1
maxReplicas: 10
maxReplicas: 2
metrics:
- type: Resource
resource:
Expand Down
9 changes: 9 additions & 0 deletions charts/operator-wandb/templates/priorityclass.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{{- if .Values.enablePriorityClass }}
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
name: wandb-high-priority
value: 10
globalDefault: false
description: "High priority pods"
{{- end }}
2 changes: 2 additions & 0 deletions charts/operator-wandb/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,3 +314,5 @@
kraft:
# This field is a UUID. It is *strongly* recommended to supply a new UUID yourself for production installs.
clusterId: "ffFF1H3AQKGdBnsqAbJKew"

enablePriorityClass: false

Check failure on line 318 in charts/operator-wandb/values.yaml

View workflow job for this annotation

GitHub Actions / lint-test 

318:27 [new-line-at-end-of-file] no new line character at the end of file
Loading