Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set Default NodeOptions #209

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Set Default NodeOptions #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/operator-wandb/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: operator-wandb
description: A Helm chart for deploying W&B to Kubernetes
type: application
version: 0.17.7
version: 0.17.8
appVersion: 1.0.0
icon: https://wandb.ai/logo.svg

Expand Down
2 changes: 1 addition & 1 deletion charts/operator-wandb/charts/console/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v2
name: console
description: A Helm chart for Kubernetes
type: application
version: 0.1.0
version: 0.1.1
appVersion: 1.16.0
2 changes: 2 additions & 0 deletions charts/operator-wandb/charts/console/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ spec:
value: "http://{{ $.Release.Name }}-prometheus-server"
- name: BANNERS
value: {{ toJson .Values.global.banners | quote }}
- name: NODE_OPTIONS
value: {{ .Values.nodeOptions }}

- name: G_HOST_IP
valueFrom:
Expand Down
4 changes: 4 additions & 0 deletions charts/operator-wandb/charts/console/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ service:
annotations: {}
labels: {}

# This is 90% of the default limit for the console in MB
# Adjust this value if you have a different limit set for the console
nodeOptions: --max-old-space-size=472

resources:
# We usually recommend not to specify default resources and to leave this as a
# conscious choice for the user. This also increases chances charts run on
Expand Down
Loading