Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadataStoreOverflow #166

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/operator-wandb/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: operator-wandb
description: A Helm chart for deploying W&B to Kubernetes
type: application
version: 0.15.1
version: 0.15.2
appVersion: 1.0.0
icon: https://wandb.ai/logo.svg

Expand Down
4 changes: 4 additions & 0 deletions charts/operator-wandb/charts/app/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ spec:
value: "{{ include "wandb.kafka.runUpdatesShadowNumPartitions" .}}"
- name: OVERFLOW_BUCKET_ADDR
value: "{{ include "app.bucket" .}}"

- name: GORILLA_METADATA_STORE_OVERFLOW
value: {{ .Values.global.metadataStoreOverflow | toJson | quote }}

- name: GORILLA_RUN_UPDATE_SHADOW_QUEUE
value: >
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ spec:
"flatRunFieldsUpdater": "kafka://$(KAFKA_CLIENT_USER):$(KAFKA_CLIENT_PASSWORD)@wandb-kafka:9092/$(KAFKA_TOPIC_RUN_UPDATE_SHADOW_QUEUE)?consumer_group_id=default-group&num_partitions=$(KAFKA_RUN_UPDATE_SHADOW_QUEUE_NUM_PARTITIONS)"
}
}

{{- if ne (include "wandb.redis.password" .) "" }}
- name: REDIS_PASSWORD
valueFrom:
Expand All @@ -149,8 +150,12 @@ spec:
value: "{{ include "wandb.redis.host" . }}"
- name: REDIS
value: "{{ include "flat-run-fields-updater.redis" . | trim }}"

- name: GORILLA_SETTINGS_CACHE
value: "{{ include "flat-run-fields-updater.redis" . | trim }}"
- name: GORILLA_METADATA_STORE_OVERFLOW
value: {{ .Values.global.metadataStoreOverflow | toJson | quote }}

{{- if and .Values.global .Values.global.observability }}
{{- if eq (default "custom" .Values.global.observability.mode) "otel" }}
- name: GORILLA_STATSD_PORT
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ spec:

- name: GORILLA_SETTINGS_CACHE
value: "{{ include "parquet.redis" . | trim }}"
- name: GORILLA_METADATA_STORE_OVERFLOW
value: {{ .Values.global.metadataStoreOverflow | toJson | quote }}

- name: BUCKET
value: "{{ include "parquet.bucket" . }}"
Expand Down
6 changes: 6 additions & 0 deletions charts/operator-wandb/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,12 @@ global:
weave-trace:
enabled: false

metadataStoreOverflow:
enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the idea is that we'll override this with channels?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

view-spec-size-threshold: 8388608
run-keys-info-size-threshold: 1048576
run-key-set-percent-threshold: 0.5

ingress:
install: true
create: true
Expand Down
Loading