Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime-v2: logYaml step #816

Merged
merged 8 commits into from
Mar 25, 2024
Merged

runtime-v2: logYaml step #816

merged 8 commits into from
Mar 25, 2024

Conversation

brig
Copy link
Contributor

@brig brig commented Oct 4, 2023 •
edited
Loading

new input param for log task: format: "yaml" to print log message as yaml:
and alias for this: logYaml

- logYaml: {k: v}
- logYaml: ${anyExpression}
- task: log
  in:
     format: "yaml"
     msg: "myMessage"

instead of

- log: ${resource.prettyPrintYaml(myMessage)}

@brig brig requested a review from a team October 4, 2023 11:18
ibodrov
ibodrov previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@ibodrov ibodrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

plugins/tasks/log/src/main/java/com/walmartlabs/concord/plugins/log/LoggingTaskV2.java Show resolved Hide resolved
@brig brig added the docs label Dec 25, 2023
@brig brig requested a review from ibodrov December 25, 2023 12:20
benbroadaway
benbroadaway previously approved these changes Mar 24, 2024
View reviewed changes
@brig brig merged commit 9bfc5af into master Mar 25, 2024
2 checks passed
@brig brig deleted the brig/v2-log-yaml branch March 25, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibodrov ibodrov ibodrov approved these changes

@benbroadaway benbroadaway benbroadaway left review comments

Assignees
No one assigned
Labels
docs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brig @ibodrov @benbroadaway