fix(windows/v3): HiddenOnTaskbar blocks keyboard focus; layered window hit-test region frozen after resize#5010
Draft
fix(windows/v3): HiddenOnTaskbar blocks keyboard focus; layered window hit-test region frozen after resize#5010
Conversation
Co-authored-by: leaanthony <1943904+leaanthony@users.noreply.github.com>
…4921) * feat(v2): add runtime.ResetSignalHandlers() for Linux panic recovery Add a new runtime function that allows users to reset signal handlers before code that might panic from nil pointer dereferences. On Linux, WebKit installs signal handlers without the SA_ONSTACK flag, which prevents Go from properly recovering from panics caused by SIGSEGV and other signals. This function adds SA_ONSTACK to the relevant signal handlers (SIGSEGV, SIGBUS, SIGFPE, SIGABRT). Usage: ```go go func() { defer func() { if err := recover(); err != nil { log.Printf("Recovered: %v", err) } }() runtime.ResetSignalHandlers() // Code that might panic... }() ``` The function is a no-op on macOS and Windows. Fixes #3965 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(v2): add panic-recovery-test example Add an example that demonstrates the Linux signal handler issue (#3965) and verifies the fix using runtime.ResetSignalHandlers(). The example includes: - A Greet function that triggers a nil pointer dereference after a delay - Auto-call from frontend after 5 seconds - README with reproduction steps Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* fix(v2): prevent wails init in non-empty directory with -d flag When using -d to specify a target directory, wails init now checks if the directory is non-empty and errors if so. This prevents accidental data loss (e.g., overwriting .git directories). Fixes #4940 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(v2): add tests for init non-empty directory check Add tests to verify: - Install fails when target directory is non-empty - Install succeeds when target directory is empty Also update changelog with the fix. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There's been a ton of improvements in the `ghw` library since the v0.13.0 release, including the update of certain transitive dependencies around Windows and Darwin support libraries. This patch simply brings in those improvements. The `v0.21.3` release of `ghw` is fully backwards-compatible with `v0.13.0`. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
Co-authored-by: leaanthony <1943904+leaanthony@users.noreply.github.com>
Co-authored-by: leaanthony <1943904+leaanthony@users.noreply.github.com>
* "Claude PR Assistant workflow" * "Claude Code Review workflow"
Co-authored-by: leaanthony <1943904+leaanthony@users.noreply.github.com>
Co-authored-by: leaanthony <1943904+leaanthony@users.noreply.github.com>
Co-authored-by: leaanthony <1943904+leaanthony@users.noreply.github.com>
Co-authored-by: leaanthony <1943904+leaanthony@users.noreply.github.com>
Co-authored-by: leaanthony <1943904+leaanthony@users.noreply.github.com>
Deploying wails with
|
| Latest commit: |
a524c67
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c45de5f8.wails.pages.dev |
| Branch Preview URL: | https://copilot-fix-issues-from-disc.wails.pages.dev |
…d layered window hit-test region Co-authored-by: leaanthony <1943904+leaanthony@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues identified in discussion 5001
fix(windows/v3): HiddenOnTaskbar blocks keyboard focus; layered window hit-test region frozen after resize
Feb 22, 2026
…3-alpha content This cleanup commit resolves the issue where the branch was accidentally based on master instead of v3-alpha. It removes all master-specific files, restores any v3-alpha files to their correct state, and ensures only the 3 intended bugfix changes differ from v3-alpha: - v3/pkg/application/webview_window_windows.go - v3/pkg/w32/constants.go - v3/pkg/w32/user32.go
|
Semgrep found 1 Risk: Affected versions of rollup are vulnerable to Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting'). Manual Review Advice: A vulnerability from this advisory is reachable if you use Rollup to bundle JavaScript with Fix: Upgrade this library to at least version 3.29.5 at wails/v3/examples/dev/frontend/package-lock.json:569. Reference(s): GHSA-gcx4-mw62-g8wm, CVE-2024-47068 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Windows-specific bugs identified in discussion #5001.
Description
Bug 1 —
HiddenOnTaskbar: trueblocks all keyboard inputWS_EX_NOACTIVATEwas used instead ofWS_EX_TOOLWINDOW.WS_EX_NOACTIVATEprevents window activation entirely — blocking keyboard focus and input.WS_EX_TOOLWINDOWis the correct style to hide from the taskbar.Bug 2 — Frameless+transparent window hit-test region frozen at creation size
On
WS_EX_LAYEREDwindows, Windows fixes the hit-testable region atCreateWindowExtime.SetWindowPosalone does not update it — after resize, the expanded area is permanently click-through.Fix: call
SetLayeredWindowAttributes(hwnd, 0, 255, LWA_ALPHA)after eachSetWindowPosinsetPhysicalBounds()to refresh the layered region.Changed files:
v3/pkg/application/webview_window_windows.go— fixHiddenOnTaskbarstyle; callSetLayeredWindowAttributesafterSetWindowPosinsetPhysicalBounds()v3/pkg/w32/user32.go— addSetLayeredWindowAttributeswrapperv3/pkg/w32/constants.go— addLWA_ALPHAandLWA_COLORKEYconstantsType of change
How Has This Been Tested?
Cross-compiled with
GOOS=windows GOARCH=amd64 go build ./pkg/w32/... ./pkg/application/...— builds clean. Runtime validation requires Windows with a frameless+transparent window.Test Configuration
Linux CI only; Windows runtime testing required by reviewer.
Checklist:
v3/UNRELEASED_CHANGELOG.mdwith details of this PR💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.