Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete page permission #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gasman
Copy link
Contributor

@gasman gasman commented Jun 6, 2020

Traditionally, Wagtail's permission model has treated page deletion as equivalent to editing, on the basis that deletion is no more destructive than editing out the content from a page, and withholding delete permission will tend to result in editors using unsatisfactory workarounds, e.g. changing titles to "DELETE ME" or "DO NOT USE". However, deletion does differ in that revision history is not preserved, which may be particularly significant in settings with strict audit logging requirements. We therefore propose splitting deletion into a separate permission type.

@emilytoppm
Copy link
Member

Generally I think this looks great, and would support adding the new permission types. I do have a few small concerns over the UI for adding/removing permissions: with the new list you propose, it's not easy to compare permissions, and particularly to see when someone is missing a permission, you have to scan the list and mentally subtract it from the list of all permissions, unlike our current design. I wonder whether a list with ticks/crosses (even if uneditable) would be clearer?

@gasman
Copy link
Contributor Author

gasman commented Jun 8, 2020

@jacobtoppm My feeling is that showing the full set of available permissions against each row (as opposed to just the currently selected ones) is too much information to be manageable, whichever way it's presented. Happy to be persuaded otherwise though :-)

Maybe we could get away with just the short permission names ('Add', 'Edit', 'Publish') being displayed in the listing, and switch to the full descriptions when editing them?

Perhaps @wagtail/ux-design can chime in...

@gasman
Copy link
Contributor Author

gasman commented Jul 1, 2020

As an addendum, the same feature has been requested for Collection-based models (Image and Document). However, as there are some extra technical details to resolve there (updating the wagtail.core.permission_policies.collections module, and working out how to avoid breaking changes to third-party models that might use collections, such as the wagtailmedia package) I propose to leave that for a future RFC.

@vinny42
Copy link

vinny42 commented Jul 19, 2020

Are there plans for solving the problems that caused this RFC: not being able to mark something as "archived" and the fact that delete is destructive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants