Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version sort support #112

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add version sort support #112

wants to merge 1 commit into from

Conversation

wader
Copy link
Owner

@wader wader commented Jun 16, 2023

No description provided.

@wader wader marked this pull request as draft June 16, 2023 18:46
@v1gnesh
Copy link
Contributor

v1gnesh commented Jun 18, 2023

What could help with this is if the dates were taken into account too (if necessary).
As you said, having a char sometimes means pre-release or alpha or whatever.

1.5.6a1
1.5.6a2
1.5.6a3
1.5.6

And it means the opposite with

1.4.5
1.4.5p1
1.4.5p2
1.4.5p3

For fetch: at least, dates are usually available in the same page as the version listings.
Not 100% sure about gitrefs.. likely to be available though.

@wader
Copy link
Owner Author

wader commented Jun 18, 2023

Good points, hmm for git i think you probably have to digg into commit blobs etc to see dates, not sure i would like to do that.

As you said about pre-release/patch-release, version sort would probably also need to kind of both constraint like semver and config how to interpret some columns. Tricky, will have to think about this a bit.

@wader wader mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants