Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webExtension.install base64 parameter name #871

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix webExtension.install base64 parameter name #871

merged 1 commit into from
Jan 29, 2025

Conversation

chrmod
Copy link
Contributor

@chrmod chrmod commented Jan 29, 2025 •
edited by pr-preview bot
Loading

base64 is declared to use value instead of the path.

Preview | Diff

@whimboo whimboo added bug Something isn't working module-webExtension labels Jan 29, 2025
whimboo
whimboo approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@whimboo whimboo merged commit 10866d1 into w3c:main Jan 29, 2025
5 checks passed
github-actions bot added a commit that referenced this pull request Jan 29, 2025
@chrmod @github-actions
Fix webExtension.install base64 parameter name (#871)
ece2dfc 
SHA: 10866d1
Reason: push, by whimboo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whimboo whimboo whimboo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working module-webExtension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrmod @whimboo