Improve CDDL syntax #870
+16
−16
Add missing comma
commit 6d709d149deab52ee53dbde697357696d2032af7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1695,7 +1695,7 @@ session.PacProxyConfiguration = ( | ||
| ) | ||
|
|
||
| session.SystemProxyConfiguration = ( | ||
| proxyType: "system", | ||
| Extensible | ||
| ) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commas are actually optional and the parser should handle that, but it is good to include them anyway as per https://datatracker.ietf.org/doc/rfc8610/#:~:text=The%0A%20%20%20%20%20%20comma%20is%20actually%20optional%20(not%20just%20in%20the%20final%20entry)%2C%20but%20it%0A%20%20%20%20%20%20is%20considered%20good%20style%20to%20set%20it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OrKoN Would you suggest adding commas on the last item as well (e.g. behind
Extensible)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this would at least help with future changes along those lines, ensuring that only the added or removed item is affected, rather than modifying an existing one just to add or remove a comma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we then keep trailing
//for the same reason?