-
Notifications
You must be signed in to change notification settings - Fork 14
Start reset of global spacing with 'base' Sass partials #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
NicolaSaunders
wants to merge
28
commits into
main
Choose a base branch
from
feature/spacing-and-markup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NicolaSaunders
commented
Aug 4, 2025
- Remove Normalize
- Introduce new global reset of styles
- Temporarily comment out vertical spacing styles
- Introduce logical properties
- Remove Normalize - Introduce new global reset of styles - Temporarily comment out vertical spacing styles - Introduce logical properties
While we look to reset/revise vertical spacing
- Add new fluid type scale using CSS custom properties (CSS variables), generated using utopia.fyi - Replace SCSS font size mixins with CSS variables for the new font sizes
To make it easier to remove old planet classnames when ready
Consistent with paragraph block margins
Lists in the nav element still have bullets and margin/padding removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.