Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version test suites #62

Merged
merged 7 commits into from
Nov 4, 2024
Merged

Version test suites #62

merged 7 commits into from
Nov 4, 2024

Conversation

aljones15
Copy link
Collaborator

  • changes the default vc to VC 2.0
  • removes klona in favor of structuredClone
  • compresses algorithms to one js file
  • removes 2 deprecated test suites

@aljones15 aljones15 self-assigned this Nov 4, 2024
@aljones15 aljones15 marked this pull request as ready for review November 4, 2024 15:47
BigBlueHat
BigBlueHat reviewed Nov 4, 2024
View reviewed changes
tests/vc-generator/validVc.js
credentialSubject: {
id: 'did:key:z6MktKwz7Ge1Yxzr4JHavN33wiwa8y81QdcMRLXQsrH9T53b'
id: 'did:key:z6MktKwz7Ge1Yxzr4JHavN33wiwa8y81QdcMRLXQsrH9T53b',
name: 'ExampleClaim'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one still worries me a bit as it's slightly above the minimum requirements--though likely a very common field even in a minimal VC. I'm open to not caring...but right now it does give me pause...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of vue, name/description are globally accessible properties in vcdm 2.0. I'm personally ok with including this.

BigBlueHat
BigBlueHat approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I think this is fine. I still mostly worry about having name in the most minimal example...but happy to be persuaded or overruled here.

@aljones15 aljones15 merged commit 6559b13 into main Nov 4, 2024
2 checks passed
@aljones15 aljones15 deleted the version-test-suites branch November 4, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigBlueHat BigBlueHat BigBlueHat approved these changes

@PatStLouis PatStLouis Awaiting requested review from PatStLouis

Assignees

@aljones15 aljones15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aljones15 @BigBlueHat @PatStLouis