Update JCS test vectors for proper handling of context #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wind4Greg
requested review from
msporny,
martyr280 and
seabass-labrax
as code owners
dlongley
approved these changes
Dec 18, 2024
msporny
approved these changes
Jan 2, 2025
|
Editorial, multiple reviews, no changes requested, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to an issue with the VC-DI-EDDSA specification: w3c/vc-di-eddsa#102 where proper context handling was missing in the JCS test vectors. This is also the case for the JCS related test vectors in this specification. These changes should have been incorporated in June 2024 but seem to have gotten lost. Resubmitting them.
Preview | Diff