-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for language and base direction #156
Conversation
b0218dc
to
d1269e0
Compare
Current state: the draft tests are about the functions and do not involve results that include literals with base direction, which is an area the RDF-Star WG has yet to get to. |
38b5927
to
6ee53b4
Compare
I believe literals with base direction are supported now: https://w3c.github.io/rdf-concepts/spec/#dfn-dir-lang-string |
Yes - whether they go under "result set" or "dir lang string" TBD. If you are happy to approve this PR, I can follow up with one with result tests. |
At first glance, the test look good, but I don't have an implementation yet to fully confirm yet (working on it). |
OK - I'll take an approval as confirming process has been followed. (More generally, as RDF-WG creates tests, putting them in as a reasonable attempt, and changing on feedback, maybe more helpful to emerging implementations at the moment.) |
+1 I have no run the tests yet but I think we can meege them and do focused follow ups if needed. Thank you for doing this work! |
Tests for SPARQL 1.2 lang changes and base direction.
Related to: w3c/sparql-query#172