add tests for rdf:JSON xsd:float and xsd:double #152
Conversation
Co-authored-by: Gregg Kellogg <[email protected]>
Co-authored-by: Gregg Kellogg <[email protected]>
| mf:action <json-array-1.ttl>; | ||
| mf:entailmentRegime "RDF"; | ||
| mf:name "json-array-unordered"; | ||
| mf:recognizedDatatypes (rdf:JSON); |
There was a problem hiding this comment.
mf:recognizedDatatypes needs to go into /ns/test-manifest.ttl.
That in turn changes the meaning of passing a test.
| trs:json-array-ordered a mf:NegativeEntailmentTest; | ||
| rdfs:comment "Arrays are ordered in rdf:JSON."; | ||
| mf:action <json-array-1.ttl>; | ||
| mf:entailmentRegime "RDF"; |
There was a problem hiding this comment.
mf:entailmentRegime needs to in /ns/test-manifest.ttl.
| mf:name "json-object-unordered"; | ||
| mf:recognizedDatatypes (rdf:JSON); | ||
| mf:result <json-object-2.ttl>; | ||
| mf:unrecognizedDatatypes (); |
There was a problem hiding this comment.
mf:unrecognizedDatatypes needs to go into /ns/test-manifest.ttl.
There was a problem hiding this comment.
These IRIs have been in the semantics tests since at least 1.1. I wonder how the 1.1 testing was done.
There was a problem hiding this comment.
Test runners don't often actually require the vocabulary terms to be defined, but it is good form to define all the terms used in tests, and pretty much everywhere else.
rdf/rdf12/rdf-semantics/manifest.ttl
Outdated
| mf:unrecognizedDatatypes (); | ||
| test:approval test:NotClassified . | ||
|
|
||
|
|
There was a problem hiding this comment.
To keep it as one commit to be merged:
- If changes have been made via teh github UI, "git pull" to you local copy of the branch.
- Edit file.
- git commit
Bonus points for doing a "squash and merge" to turn it into one commit going onto to main.
There was a problem hiding this comment.
You can also add multiple suggestions into a batch in the UI which will create just one commit. This is done from the "Files changed" view and you'll see a button to "add to batch".
There was a problem hiding this comment.
/ns/test-manifest.ttl needs updating. I've picked out some terms that need to be defined - there may be others.
Co-authored-by: Gregg Kellogg <[email protected]>
|
Is all OK now? #153 has been opened for the IRIs missing in test-manifest.ttl |
Co-authored-by: Gregg Kellogg <[email protected]>
Tests for rounding of numbers and treatment of large numbers.
Tests for difference between positive and negative zero.
Tests for order dependence of rdf:JSON arrays and order independence of rdf:JSON objects.